Merge lp:~unity-team/dialer-app/dialer-app-dgu into lp:dialer-app

Proposed by Gerry Boland
Status: Merged
Approved by: Bill Filler
Approved revision: 514
Merged at revision: 525
Proposed branch: lp:~unity-team/dialer-app/dialer-app-dgu
Merge into: lp:dialer-app
Diff against target: 44 lines (+10/-6)
2 files modified
src/qml/DialerPage/KeypadEntry.qml (+4/-0)
src/qml/dialer-app.qml (+6/-6)
To merge this branch: bzr merge lp:~unity-team/dialer-app/dialer-app-dgu
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+286476@code.launchpad.net

Commit message

Fixes for dynamic grid units support: set implicit sizes on MainView, and have min/max window size update on GU change

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
515. By Nick Dedekind

added keypad input dgu change handler

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/DialerPage/KeypadEntry.qml'
2--- src/qml/DialerPage/KeypadEntry.qml 2016-03-11 19:43:02 +0000
3+++ src/qml/DialerPage/KeypadEntry.qml 2016-04-27 10:02:49 +0000
4@@ -128,6 +128,10 @@
5 }
6
7 onContentWidthChanged: adjustTextSize()
8+ Connections {
9+ target: units
10+ onGridUnitChanged: input.adjustTextSize()
11+ }
12 }
13
14 MouseArea {
15
16=== modified file 'src/qml/dialer-app.qml'
17--- src/qml/dialer-app.qml 2016-03-17 22:01:50 +0000
18+++ src/qml/dialer-app.qml 2016-04-27 10:02:49 +0000
19@@ -65,8 +65,8 @@
20 }
21
22 automaticOrientation: false
23- width: units.gu(40)
24- height: units.gu(71)
25+ implicitWidth: units.gu(40)
26+ implicitHeight: units.gu(71)
27
28 property bool hasCalls: callManager.hasCalls
29
30@@ -479,10 +479,10 @@
31 pageStackNormalMode.push(Qt.createComponent("DialerPage/DialerPage.qml"))
32
33 // when running in windowed mode, do not allow resizing
34- view.minimumWidth = width * 0.9
35- view.maximumWidth = width * 1.1
36- view.minimumHeight = height * 0.9
37- view.maximumHeight = height * 1.1
38+ view.minimumWidth = Qt.binding( function() { return implicitWidth * 0.9; } )
39+ view.maximumWidth = Qt.binding( function() { return implicitWidth * 1.1; } )
40+ view.minimumHeight = Qt.binding( function() { return implicitHeight * 0.9; } )
41+ view.maximumHeight = Qt.binding( function() { return implicitHeight * 1.1; } )
42
43 // if there are calls, even if we don't have info about them yet, push the livecall view
44 if (callManager.hasCalls) {

Subscribers

People subscribed via source and target branches