dee

Merge lp:~unity-team/dee/gdbus into lp:dee

Proposed by Mikkel Kamstrup Erlandsen on 2010-12-14

Status:

Merged

Merged at revision:

194

Proposed branch:

Merge into:

Diff against target:

0 lines

To merge this branch:

bzr merge lp:~unity-team/dee/gdbus

Related bugs:

Bug #622448: Port Dee to GDBus	High	Fix Released
Bug #622454: Optimize DBus API for Dee	Medium	Fix Released
Bug #675563: Dee connect method isn't python friendly	High	Fix Released
Bug #675870: GVariant based API instead of GValue based	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Neil J. Patel (community)		2010-12-14	Approve on 2010-12-15
Review via email: mp+43648@code.launchpad.net

It's the big one... I think the primary thing to review is the new model API. The impl details will take days :-)

All the unit tests (+ some new ones) are passing. Note that in order to pass all unit tests a bug-fix to gdbus is required: https://bugzilla.gnome.org/show_bug.cgi?id=637220

lp:~unity-team/dee/gdbus updated on 2010-12-15

221. By Mikkel Kamstrup Erlandsen on 2010-12-15: Use pointers to va_lists in the API in order to work with newer gccs where the va_list implementation has changed slightly causing build failures on Natty (works with gcc 4.4.4 in Maverick, but fails to build with gcc 4.5.2 in Natty)
222. By Neil J. Patel on 2010-12-15: Add libs otherwise won't compile on natty

Revision history for this message

Neil J. Patel (njpatel) wrote on 2010-12-15:

Looks good, natty issues are fixed (I've pushed up a fix for examples and tests) so approved :) Nice work!

review: Approve

Empty

People subscribed via source and target branches

to all changes: