Merge lp:~unity-team/dee/gdbus into lp:dee
Proposed by
Mikkel Kamstrup Erlandsen
on 2010-12-14
| Status: | Merged | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 194 | ||||||||||||||||
| Proposed branch: | lp:~unity-team/dee/gdbus | ||||||||||||||||
| Merge into: | lp:dee | ||||||||||||||||
| Diff against target: | 0 lines | ||||||||||||||||
| To merge this branch: | bzr merge lp:~unity-team/dee/gdbus | ||||||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neil J. Patel (community) | 2010-12-14 | Approve on 2010-12-15 | |
|
Review via email:
|
|||
Description of the Change
It's the big one... I think the primary thing to review is the new model API. The impl details will take days :-)
All the unit tests (+ some new ones) are passing. Note that in order to pass all unit tests a bug-fix to gdbus is required: https:/
To post a comment you must log in.
lp:~unity-team/dee/gdbus
updated
on 2010-12-15
- 221. By Mikkel Kamstrup Erlandsen on 2010-12-15
-
Use pointers to va_lists in the API in order to work with newer gccs where the va_list implementation has changed slightly causing build failures on Natty (works with gcc 4.4.4 in Maverick, but fails to build with gcc 4.5.2 in Natty)
- 222. By Neil J. Patel on 2010-12-15
-
Add libs otherwise won't compile on natty
Looks good, natty issues are fixed (I've pushed up a fix for examples and tests) so approved :) Nice work!