Compiz

Merge lp:~unity-team/compiz/work-around-glibmm-bug-561885 into lp:~unity-team/compiz/trunk

  1. work-around-glibmm-bug-561885
  2. Merge into trunk
Proposed by Loïc Molinari
Status: Merged
Merged at revision: 2742
Proposed branch: lp:~unity-team/compiz/work-around-glibmm-bug-561885
Merge into: lp:~unity-team/compiz/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~unity-team/compiz/work-around-glibmm-bug-561885
Reviewer Review Type Date Requested Status
Sam Spilsbury (community) Approve
Review via email: mp+56977@code.launchpad.net

Description of the change

That branch is work around for Glibmm bug https://bugzilla.gnome.org/show_bug.cgi?id=561885.

By not requesting to destroy the event source after stopping the mainloop in the event source callback, it avoids a crash in PrivateScreen::~PrivateScreen trying to free the event GSource that's already been freed.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Looks good - its a shame that there's no refguard here in glibmm when the underly GSource gets destroyed because the we returned false in the callback function, but its fine to keep it around since it goes away explicitly on the destructor.

review: Approve
lp:~unity-team/compiz/work-around-glibmm-bug-561885 updated
2740. By Loïc Molinari

Switch to C style comments as requested by Compiz style guide

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: