Merge lp:~unity-team/compiz/trunk.fix-xterms into lp:~unity-team/compiz/trunk

Proposed by Sam Spilsbury
Status: Merged
Merge reported by: David Barth
Merged at revision: not available
Proposed branch: lp:~unity-team/compiz/trunk.fix-xterms
Merge into: lp:~unity-team/compiz/trunk
Diff against target: 151 lines (+37/-34)
2 files modified
src/window.cpp (+7/-7)
src/windowgeometry.cpp (+30/-27)
To merge this branch: bzr merge lp:~unity-team/compiz/trunk.fix-xterms
Reviewer Review Type Date Requested Status
Loïc Molinari (community) Approve
Review via email: mp+56144@code.launchpad.net

Description of the change

Fixes xterms

To post a comment you must log in.
Revision history for this message
Loïc Molinari (loic.molinari) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/window.cpp'
2--- src/window.cpp 2011-03-27 04:14:46 +0000
3+++ src/window.cpp 2011-04-04 12:19:18 +0000
4@@ -1632,9 +1632,9 @@
5 return;
6
7 x = ce->x + priv->input.left;
8- y = ce->y + priv->input.top;
9- width = ce->width - priv->input.left - priv->input.right;
10- height = ce->height - priv->input.top - priv->input.bottom;
11+ y = ce->y + priv->input.top - priv->serverGeometry.border ();
12+ width = ce->width - priv->serverGeometry.border () * 2 - priv->input.left - priv->input.right;
13+ height = ce->height - priv->serverGeometry.border () * 2 - priv->input.top - priv->input.bottom;
14
15 if (priv->syncWait)
16 {
17@@ -2429,10 +2429,10 @@
18 {
19 XWindowChanges wc = *xwc;
20
21- wc.x -= input.left;
22- wc.y -= input.top;
23- wc.width += input.left + input.right;
24- wc.height += input.top + input.bottom;
25+ wc.x -= input.left - serverGeometry.border ();
26+ wc.y -= input.top - serverGeometry.border ();
27+ wc.width += input.left + input.right + serverGeometry.border ();
28+ wc.height += input.top + input.bottom + serverGeometry.border ();
29
30 XConfigureWindow (screen->dpy (), frame, valueMask, &wc);
31 valueMask &= ~(CWSibling | CWStackMode);
32
33=== modified file 'src/windowgeometry.cpp'
34--- src/windowgeometry.cpp 2011-03-14 16:12:45 +0000
35+++ src/windowgeometry.cpp 2011-04-04 12:19:18 +0000
36@@ -103,19 +103,22 @@
37 int
38 CompWindow::width () const
39 {
40- return priv->width;
41+ return priv->width +
42+ priv->geometry.border () * 2;
43 }
44
45 int
46 CompWindow::height () const
47 {
48- return priv->height;
49+ return priv->height +
50+ priv->geometry.border () * 2;;
51 }
52
53 CompSize
54 CompWindow::size () const
55 {
56- return CompSize (priv->width, priv->height);
57+ return CompSize (priv->width + priv->geometry.border () * 2,
58+ priv->height + priv->geometry.border () * 2);
59 }
60
61 int
62@@ -164,65 +167,65 @@
63 CompRect
64 CompWindow::borderRect () const
65 {
66- return CompRect (priv->geometry.x () - priv->border.left,
67- priv->geometry.y () - priv->border.top,
68- priv->geometry.width () +
69+ return CompRect (priv->geometry.x () - priv->geometry.border () - priv->border.left,
70+ priv->geometry.y () - priv->geometry.border () - priv->border.top,
71+ priv->geometry.width () + priv->geometry.border () * 2 +
72 priv->border.left + priv->border.right,
73- priv->geometry.height () +
74+ priv->geometry.height () + priv->geometry.border () * 2 +
75 priv->border.top + priv->border.bottom);
76 }
77
78 CompRect
79 CompWindow::serverBorderRect () const
80 {
81- return CompRect (priv->serverGeometry.x () - priv->border.left,
82- priv->serverGeometry.y () - priv->border.top,
83- priv->serverGeometry.width () +
84+ return CompRect (priv->serverGeometry.x () - priv->geometry.border () - priv->border.left,
85+ priv->serverGeometry.y () - priv->geometry.border () - priv->border.top,
86+ priv->serverGeometry.width () + priv->geometry.border () * 2 +
87 priv->border.left + priv->border.right,
88- priv->serverGeometry.height () +
89+ priv->serverGeometry.height () + priv->geometry.border () * 2 +
90 priv->border.top + priv->border.bottom);
91 }
92
93 CompRect
94 CompWindow::inputRect () const
95 {
96- return CompRect (priv->geometry.x () - priv->input.left,
97- priv->geometry.y () - priv->input.top,
98- priv->geometry.width () +
99+ return CompRect (priv->geometry.x () - priv->geometry.border () - priv->input.left,
100+ priv->geometry.y () - priv->geometry.border () - priv->input.top,
101+ priv->geometry.width () + priv->geometry.border () * 2 +
102 priv->input.left + priv->input.right,
103- priv->geometry.height () +
104+ priv->geometry.height () +priv->geometry.border () * 2 +
105 priv->input.top + priv->input.bottom);
106 }
107
108 CompRect
109 CompWindow::serverInputRect () const
110 {
111- return CompRect (priv->serverGeometry.x () - priv->input.left,
112- priv->serverGeometry.y () - priv->input.top,
113- priv->serverGeometry.width () +
114+ return CompRect (priv->serverGeometry.x () - priv->serverGeometry.border () - priv->input.left,
115+ priv->serverGeometry.y () - priv->serverGeometry.border () - priv->input.top,
116+ priv->serverGeometry.width () + priv->serverGeometry.border () * 2 +
117 priv->input.left + priv->input.right,
118- priv->serverGeometry.height () +
119+ priv->serverGeometry.height () + priv->serverGeometry.border () * 2 +
120 priv->input.top + priv->input.bottom);
121 }
122
123 CompRect
124 CompWindow::outputRect () const
125 {
126- return CompRect (priv->geometry.x () - priv->output.left,
127- priv->geometry.y () - priv->output.top,
128- priv->geometry.width () +
129+ return CompRect (priv->geometry.x () - priv->serverGeometry.border ()- priv->output.left,
130+ priv->geometry.y () - priv->serverGeometry.border () - priv->output.top,
131+ priv->geometry.width () + priv->serverGeometry.border () * 2 +
132 priv->output.left + priv->output.right,
133- priv->geometry.height () +
134+ priv->geometry.height () + priv->serverGeometry.border () * 2 +
135 priv->output.top + priv->output.bottom);
136 }
137
138 CompRect
139 CompWindow::serverOutputRect () const
140 {
141- return CompRect (priv->serverGeometry.x () - priv->output.left,
142- priv->serverGeometry.y () - priv->output.top,
143- priv->serverGeometry.width () +
144+ return CompRect (priv->serverGeometry.x () - priv->serverGeometry.border () - priv->output.left,
145+ priv->serverGeometry.y () - priv->serverGeometry.border () - priv->output.top,
146+ priv->serverGeometry.width () + priv->serverGeometry.border () * 2 +
147 priv->output.left + priv->output.right,
148- priv->serverGeometry.height () +
149+ priv->serverGeometry.height () + priv->serverGeometry.border () * 2 +
150 priv->output.top + priv->output.bottom);
151 }

Subscribers

People subscribed via source and target branches

to all changes: