Compiz Core

Merge lp:~unity-team/compiz-core/core.fix_events_going_to_frames into lp:compiz-core/trunk

  1. core.fix_events_going_to_frames
  2. Merge into trunk
Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 2753
Proposed branch: lp:~unity-team/compiz-core/core.fix_events_going_to_frames
Merge into: lp:compiz-core/trunk
Diff against target: 19 lines (+9/-0)
1 file modified
src/window.cpp (+9/-0)
To merge this branch: bzr merge lp:~unity-team/compiz-core/core.fix_events_going_to_frames
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Sam Spilsbury Pending
Review via email: mp+62232@code.launchpad.net

Commit message

Fixes LP#795065

Description of the change

Fix frame windows hanging around during animations

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :

+1 like the big explanitory comment

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/window.cpp'
2--- src/window.cpp 2011-04-30 14:11:10 +0000
3+++ src/window.cpp 2011-05-25 03:21:24 +0000
4@@ -1313,6 +1313,15 @@
5 if (priv->mapNum)
6 priv->mapNum = 0;
7
8+ /* Even though we're still keeping the backing
9+ * pixmap of the window around, it's safe to
10+ * unmap the frame window since there's no use
11+ * for it at this point anyways and it just blocks
12+ * input */
13+
14+ XUnmapWindow (screen->dpy (), priv->wrapper);
15+ XUnmapWindow (screen->dpy (), priv->frame);
16+
17 priv->unmapRefCnt--;
18 if (priv->unmapRefCnt > 0)
19 return;

Subscribers

People subscribed via source and target branches

to all changes: