Merge lp:~unity-team/clutk/clutk.fix-icon-clipping-on-launcher into lp:clutk

Proposed by Jay Taoko
Status: Merged
Approved by: Mirco Müller
Approved revision: no longer in the revision history of the source branch.
Merged at revision: 271
Proposed branch: lp:~unity-team/clutk/clutk.fix-icon-clipping-on-launcher
Merge into: lp:clutk
Diff against target: 49 lines (+8/-3)
2 files modified
clutk/ctk-arb-asm-private.c (+2/-1)
clutk/ctk-effect-cache.c (+6/-2)
To merge this branch: bzr merge lp:~unity-team/clutk/clutk.fix-icon-clipping-on-launcher
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Review via email: mp+35734@code.launchpad.net

Description of the change

This is a possible fix for the clipping of icons at the right border of the launcher when dragging.

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

Why is there also a diff for gtk-doc.make?

review: Needs Information
Revision history for this message
Mirco Müller (macslow) wrote :

Make sure you do "bzr diff >delta.patch" remove the gtk-doc.make related part and only apply the remainder to clutk trunk when you merge.

271. By Jay Taoko

This is a possible fix for the clipping of icons at the right border of the launcher when dragging.

Revision history for this message
Mirco Müller (macslow) wrote :

Code is ok, compiled, runs and no clipping of icon while dragging. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clutk/ctk-arb-asm-private.c'
2--- clutk/ctk-arb-asm-private.c 2010-07-27 04:01:05 +0000
3+++ clutk/ctk-arb-asm-private.c 2010-09-16 21:09:52 +0000
4@@ -1054,6 +1054,7 @@
5 CHECKGL( glLoadIdentity() );
6 }
7
8+ glDisable(GL_BLEND);
9 glColor4f(1.0f, 1.0f, 1.0f, 1.0f);
10 glBegin(GL_QUADS);
11 {
12@@ -1070,7 +1071,7 @@
13 glVertex4f(x_dst+w_dst, y_dst, 0, 1.0f);
14 }
15 glEnd();
16-
17+ glEnable(GL_BLEND);
18 /* Restore model-view and projection matrices */
19 {
20 CHECKGL( glMatrixMode(GL_PROJECTION) );
21
22=== modified file 'clutk/ctk-effect-cache.c'
23--- clutk/ctk-effect-cache.c 2010-08-20 16:41:32 +0000
24+++ clutk/ctk-effect-cache.c 2010-09-16 21:09:52 +0000
25@@ -259,10 +259,14 @@
26 &actor_screen_width,
27 &actor_screen_height, vtx);
28
29+ int BorderMargin = 10;
30+
31 actor_screen_y = ceilf (actor_screen_y);
32- actor_screen_width = ceilf(actor_screen_width);
33+ actor_screen_width = ceilf(actor_screen_width) + BorderMargin;
34 actor_screen_height = ceilf(actor_screen_height);
35
36+
37+
38 if (/*(priv->invalidate_texture_cache == TRUE) &&*/ priv->update_texture_cache)
39 {
40 /* reserve 2 render targets */
41@@ -400,7 +404,7 @@
42 1.0f,
43 1.0f);
44 }
45-
46+
47
48 /* leave and make sure the top render target on the stack is binded */
49 if (top_rt)

Subscribers

People subscribed via source and target branches