lp:~unity-team/bamf/bamf.prevent-double-add

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:bamf/0.4 at revision 436

Tim Penhey (community): Approve on 2012-02-07

Diff: 8713 lines (+1/-8650)

11 files modified

lib/libbamf/bamf-view.c (+1/-1)
m4/expansions.m4 (+0/-50)
m4/i18n.m4 (+0/-13)
m4/introspection.m4 (+0/-96)
m4/libtool.m4 (+0/-7851)
m4/ltoptions.m4 (+0/-369)
m4/ltsugar.m4 (+0/-123)
m4/ltversion.m4 (+0/-23)
m4/lt~obsolete.m4 (+0/-98)
m4/programs.m4 (+0/-15)
m4/util.m4 (+0/-11)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #928014: BAMF adds children twice to the local cache if the cache is updated before a child-added signal is received

High

Fix Released

Link a bug report

Related blueprints

441. By Jason Smith on 2012-02-10

update because ted and desrt cant name things clearly

440. By Jason Smith on 2012-02-10

update to match dbusmenu changes

439. By Marco Trevisan (Treviño) on 2012-02-09

Some bool are returned on non-gboolean functions, fixed them plus a gerror memory leak. Fixes: . Approved by Michal Hruby.

438. By Sven Baars on 2012-02-09

This should fix

==1933== 96 bytes in 8 blocks are definitely lost in loss record 8,181 of 10,585
==1933== at 0x4C296CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1933== by 0x6710918: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1933== by 0x6702A4C: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1933== by 0x6703DDF: g_key_file_get_string (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1933== by 0x2366A677: bamf_application_new_favorite (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1933== by 0x2366F34F: bamf_factory_app_for_file (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1933== by 0x2366C023: bamf_matcher_get_application_for_desktop_file (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1933== by 0x22D83554: unity::launcher::Controller::Impl::CreateFavorite(char const*) (in /usr/lib/compiz/libunityshell.so)
==1933== by 0x22D8623B: unity::launcher::Controller::Impl::SetupBamf() (in /usr/lib/compiz/libunityshell.so)
==1933== by 0x22D865A8: ??? (in /usr/lib/compiz/libunityshell.so)
==1933== by 0x670B76A: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1933== by 0x670AB29: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0). Fixes: . Approved by Michal Hruby.

437. By Sven Baars on 2012-02-08

This should fix

==1994== 49 (16 direct, 33 indirect) bytes in 1 blocks are definitely lost in loss record 11,086 of 25,065
==1994== at 0x4C296CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1994== by 0x4C29857: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1994== by 0x670D9D6: g_realloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1994== by 0x66DCB58: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1994== by 0x66DCCD3: g_array_sized_new (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1994== by 0x10EC9D96: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==1994== by 0x10ECAAD4: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==1994== by 0x10EC437C: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==1994== by 0x10EC769A: dbus_g_proxy_call (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==1994== by 0x1B0DB81E: bamf_view_get_children (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1994== by 0x19EE94B3: unity::launcher::BamfLauncherIcon::EnsureWindowState() (in /usr/lib/compiz/libunityshell.so)
==1994== by 0x19EE9B87: unity::launcher::BamfLauncherIcon::BamfLauncherIcon(_BamfApplication*) (in /usr/lib/compiz/libunityshell.so). Fixes: . Approved by Mikkel Kamstrup Erlandsen.

436. By Marco Trevisan (Treviño) on 2012-02-07

Makes bamf not double add items if the user calls get_children before a child-added signal arrives.. Fixes: https://bugs.launchpad.net/bugs/928014. Approved by Tim Penhey.

435. By Didier Roche-Tolomelli on 2012-02-03

releasing 0.2.108

434. By Marco Trevisan (Treviño) on 2012-01-28

Libreoffice desktop files have changed the exec parameter in last upgrade, we need to match them correctly.

Code updated to support both the old and the new lo .desktop files.. Fixes: https://bugs.launchpad.net/bugs/919892. Approved by Jason Smith.

433. By Marco Trevisan (Treviño) on 2012-01-28

Fixed bug bug #801784 making gnome-control-center to rematch in BAMF

Used a similar hack used for re-matching libreoffice. Here the gnome-control-center window is rematched when its name changes, getting its ID from the defined WM_WINDOW_ROLE.

Also I've fixed a bug that caused all the gnome-control-center desktop to be ignored by the matcher, only the last parsed was considered by bamf before (due to this when doing "gnome-control-center display" in a terminal, the window was matched as a generic g-c-c window, not as the display one). To do this, I've added a white-list regex to match the prefixes that must not be ignored and that should be included into the exec string (I guess that this can be useful also for fixing the matching of the wine apps).

Note that this branch to work correctly needs lp:~3v1n0/ubuntu/precise/gnome-control-center/add-window-role-to-panels
If no patched gnome-control-center is found, all the gnome-control-center windows will always be shown as generic g-c-c windows.. Fixes: https://bugs.launchpad.net/bugs/801784. Approved by .

432. By Marco Trevisan (Treviño) on 2012-01-27

Fixed bug #919366 that was caused by the fact that the list of the cached children were not correctly updated on children removal.

Reffing the objects on the list and manually looking for the removed one, does the work.
In the case we can't find the removed object, we just free the cached list, that will be eventually repopulated on next request.. Fixes: https://bugs.launchpad.net/bugs/919366. Approved by Jason Smith.