Merge lp:~unity-api-team/unity8/unlock-all-modems-on-boot-rtm into lp:unity8/rtm-14.09

Proposed by Antti Kaijanmäki
Status: Merged
Approved by: Michał Sawicz
Approved revision: 1355
Merged at revision: 1359
Proposed branch: lp:~unity-api-team/unity8/unlock-all-modems-on-boot-rtm
Merge into: lp:unity8/rtm-14.09
Diff against target: 40 lines (+2/-5)
3 files modified
debian/control (+1/-1)
qml/Shell.qml (+1/-2)
tests/qmltests/tst_Shell.qml (+0/-2)
To merge this branch: bzr merge lp:~unity-api-team/unity8/unlock-all-modems-on-boot-rtm
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Michael Terry Needs Fixing
Review via email: mp+238359@code.launchpad.net

Commit message

Unlock all modems on boot.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

LGTM, tested in RTM.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 Yes

 * Did CI run pass? If not, please explain why.
 TBD

 * Did you make sure that the branch does not contain spurious tags?
 Yes

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

As marked in the other MP, this needs a test fix too.

review: Needs Fixing
1355. By Antti Kaijanmäki

re-enable tst_unlockAllModemsOnBoot

Revision history for this message
Michał Sawicz (saviq) wrote :

As per the trunk MP.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-10-06 08:00:45 +0000
3+++ debian/control 2014-10-15 09:05:48 +0000
4@@ -97,7 +97,7 @@
5 Recommends: unity-scope-click,
6 unity-scope-mediascanner2,
7 unity-scope-scopes,
8-Breaks: indicator-network (<< 0.5.1),
9+Breaks: indicator-network (<< 0.5.1+14.10.20141014),
10 ubuntu-touch-session (<< 0.107),
11 unity8-greeter (<< 7.89),
12 Replaces: ubuntu-touch-session (<< 0.82~),
13
14=== modified file 'qml/Shell.qml'
15--- qml/Shell.qml 2014-10-08 20:36:48 +0000
16+++ qml/Shell.qml 2014-10-15 09:05:48 +0000
17@@ -533,10 +533,9 @@
18 }
19 }
20
21- /* TODO re-enable when the corresponding changes in the service land (LP: #1361074)
22 Component.onCompleted: {
23 Connectivity.unlockAllModems()
24- } */
25+ }
26
27 onUnlocked: greeter.hide()
28 onSelected: {
29
30=== modified file 'tests/qmltests/tst_Shell.qml'
31--- tests/qmltests/tst_Shell.qml 2014-10-06 16:39:10 +0000
32+++ tests/qmltests/tst_Shell.qml 2014-10-15 09:05:48 +0000
33@@ -549,8 +549,6 @@
34 }
35
36 function test_unlockAllModemsOnBoot() {
37- // TODO reenable when service ready (LP: #1361074)
38- expectFail("", "Unlock on boot temporarily disabled");
39 tryCompare(unlockAllModemsSpy, "count", 1)
40 }
41

Subscribers

People subscribed via source and target branches

to all changes: