Merge lp:~unity-api-team/unity8/scopes-active-depends-on-screen into lp:unity8

[Pete Woods]

Only set scopes active when the screen is on

Only set scopes active when the screen is on

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1622
http://jenkins.qa.ubuntu.com/job/unity8-ci/5353/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1483
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/517
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/518
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/518
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1317
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1481
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1481/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18270

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5353/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

How does this work with

  https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1422309

The idea behind that bug is that the scope should refresh itself and tell the ui, but if the ui has set it to not active, why would it refresh itself?

review: Needs Information

[Pete Woods (pete-woods)]

This shouldn't affect the behaviour of anything related to that. Scopes shouldn't be being regularly refreshed while the phone is suspended. The solution to that bug would be to add the TTL property to the scope's results. This would cause the scope results to be invalidated after a certain period, and refreshed as soon as the scope becomes active again.

[Albert Astals Cid (aacid)]

Not sure about that, as a user what i want is the scope being refreshed already when i power on the screen, not it having old data and then after a few seconds i am seeing wrong data (since it's not today anymore) it being refreshed with the good data.

[Pete Woods (pete-woods)]

Well the scope would start refreshing as soon as the screen comes on, by the time you've swiped the greeter out of the way, and possibly entered your password, it will have refreshed.

[Albert Astals Cid (aacid)]

This sets the isActive variable of scopes to false as intended, it doesn't fix the bug linked from the description because other pieces need to fall into place.

I'm not top-approving this since I don't want us to later realize this is not the fix we need when coding the lower parts of the fix and end up with a half-fix that does nothing.

review: Approve (code)

[Ricardo Salveti (rsalveti)]

Works quite well when testing it, it starts gps again right after resuming the device.

review: Approve

[Albert Astals Cid (aacid)]

Ricardo, you tested it alone? Last time i tested on vivid-proposed + this branch it did not stop/start the gps, has anything landed that may fix that? Or you used any other branch in addition to this one?

[Ricardo Salveti (rsalveti)]

I tested with RTM / krillin as the GPS service is working properly in there. We're about to land some additional location-service fixes for vivid only, which should make it to fully work again in there.

=== modified file 'qml/Dash/GenericScopeView.qml'
--- qml/Dash/GenericScopeView.qml	2015-02-11 17:10:44 +0000
+++ qml/Dash/GenericScopeView.qml	2015-02-23 12:05:57 +0000
@@ -19,6 +19,7 @@
 import Utils 0.1
 import Unity 0.2
 import Dash 0.1
+import Powerd 0.1
 import "../Components"
 import "../Components/ListItems" as ListItems
 
@@ -104,7 +105,7 @@
     Binding {
         target: scope
         property: "isActive"
-        value: isCurrent && !subPageLoader.open
+        value: isCurrent && !subPageLoader.open && (Powerd.status === Powerd.On)
     }
 
     UnitySortFilterProxyModel {