Merge lp:~unity-api-team/unity8/rtm-gps-overactive into lp:unity8/rtm-14.09

Proposed by dobey
Status: Merged
Merged at revision: 1422
Proposed branch: lp:~unity-api-team/unity8/rtm-gps-overactive
Merge into: lp:unity8/rtm-14.09
Diff against target: 25 lines (+2/-2)
2 files modified
qml/Dash/Dash.qml (+1/-1)
qml/Dash/GenericScopeView.qml (+1/-1)
To merge this branch: bzr merge lp:~unity-api-team/unity8/rtm-gps-overactive
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
Review via email: mp+255266@code.launchpad.net

Commit message

GPS only goes active when the Dash is in the foreground

Description of the change

GPS only goes active when the Dash is in the foreground

To post a comment you must log in.
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

current build number: 263
device name: krillin
channel: ubuntu-touch/ubuntu-rtm/14.09-proposed
last update: 2015-04-06 10:12:37
version version: 263
version ubuntu: 20150403.1
version device: 20150327-f7072d0
version custom: 20150216-561-29-186

Tested and works as expected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/Dash.qml'
2--- qml/Dash/Dash.qml 2015-01-13 19:06:35 +0000
3+++ qml/Dash/Dash.qml 2015-04-06 14:13:45 +0000
4@@ -179,7 +179,7 @@
5 Binding {
6 target: scopesList.scope
7 property: "isActive"
8- value: bottomEdgeController.progress === 1
9+ value: bottomEdgeController.progress === 1 && Qt.application.active
10 }
11
12 Connections {
13
14=== modified file 'qml/Dash/GenericScopeView.qml'
15--- qml/Dash/GenericScopeView.qml 2015-02-23 11:34:59 +0000
16+++ qml/Dash/GenericScopeView.qml 2015-04-06 14:13:45 +0000
17@@ -105,7 +105,7 @@
18 Binding {
19 target: scope
20 property: "isActive"
21- value: isCurrent && !subPageLoader.open && (Powerd.status === Powerd.On)
22+ value: isCurrent && !subPageLoader.open && Qt.application.active
23 }
24
25 SortFilterProxyModel {

Subscribers

People subscribed via source and target branches

to all changes: