Merge lp:~unity-api-team/unity8/pinunlock-ng into lp:unity8
Proposed by
Antti Kaijanmäki
Status: | Rejected |
---|---|
Rejected by: | Michael Zanetti |
Proposed branch: | lp:~unity-api-team/unity8/pinunlock-ng |
Merge into: | lp:unity8 |
Diff against target: |
129 lines (+38/-5) 4 files modified
qml/Components/PinPadButton.qml (+1/-1) qml/Greeter/Lockscreen.qml (+10/-0) qml/Greeter/PinLockscreen.qml (+23/-3) qml/Notifications/NotificationMenuItemFactory.qml (+4/-1) |
To merge this branch: | bzr merge lp:~unity-api-team/unity8/pinunlock-ng |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Zanetti (community) | Disapprove | ||
Review via email:
|
To post a comment you must log in.
Unmerged revisions
- 856. By Antti Kaijanmäki
-
Increase the height of the PinLockScreen pinEntry shape to make room for the pin retry count.
- 855. By Antti Kaijanmäki
-
minmax init
49 + property var pinMinMax : [4, 8]
Don't set this as default for all PinlockScreens. Keep it null in here and only set it in NotificationMen uItemFactory.