Merge lp:~unity-api-team/unity8/lp-1434379-gps-overactive into lp:unity8

[Pete Woods]

GPS only goes active when the Dash is in the foreground

GPS only goes active when the Dash is in the foreground

[Albert Astals Cid (aacid)]

Hmmm, does this mean that when going back to the dash it will either show empty (because no scope was active) or the backend will retrigger a search (because it wehnt from inactive to active)?

[Michał Sawicz (saviq)]

There's another instance that probably needs this:

qml/Dash/Dash.qml:180: property: "isActive"
qml/Dash/Dash.qml-181- value: bottomEdgeController.progress === 1
qml/Dash/Dash.qml-182- }

You will also need to tweak those tests to boot:

tests/qmltests/Dash/tst_DashContent.qml:229: function test_is_active(data) {

tests/qmltests/Dash/tst_GenericScopeView.qml:112: function test_isActive() {

review: Needs Fixing

[Michał Sawicz (saviq)]

> Hmmm, does this mean that when going back to the dash it will either show empty (because no scope was active) or the backend will retrigger a search (because it wehnt from inactive to active)?

It will retrigger on focus.

[Albert Astals Cid (aacid)]

That didn't happen before, did it? Is something we want?

[Michał Sawicz (saviq)]

> That didn't happen before, did it? Is something we want?

It did happen before, just it might have happened before you typed your
passcode in. And regardless whether you did. So it kicked in even when
you got a text, or when you just woke up the phone to see the clock.

Now it will only happen when you actually focused the dash.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1706
http://jenkins.qa.ubuntu.com/job/unity8-ci/5516/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2104
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/679
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/681
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/681
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1852
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2102
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2102/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19387

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5516/rebuild

review: Needs Fixing (continuous-integration)

[dobey (dobey)]

I've made the two code changes requested by Saviq. I don't understand what should be changed in the mentioned tests though. These two tests still pass, and I don't think Qt.application.active is writable.

[Daniel d'Andrada (dandrader)]

About Qt.application.active:
"Deprecated, use Qt.application.state == Qt.ApplicationActive instead."

[Daniel d'Andrada (dandrader)]

> About Qt.application.active:
> "Deprecated, use Qt.application.state == Qt.ApplicationActive instead."

Other than that, it looks ok to me.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1707
http://jenkins.qa.ubuntu.com/job/unity8-ci/5520/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2117
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/683
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/685/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/685
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1864
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2115
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19418

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5520/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

> I've made the two code changes requested by Saviq. I don't understand what
> should be changed in the mentioned tests though. These two tests still pass,
> and I don't think Qt.application.active is writable.

Indeed, we'd need to build a way into our QPA plugin to allow overriding that.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1707
http://jenkins.qa.ubuntu.com/job/unity8-ci/5521/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2121
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/684
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/686
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/686
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1868
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2119
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2119/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19434

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5521/rebuild

review: Needs Fixing (continuous-integration)

[lp:~unity-api-team/unity8/lp-1434379-gps-overactive]

1706. By Pete Woods on 2015-04-08

Only have scopes active when the app is focused

1707. By Pete Woods on 2015-04-08

Respond to Daniel's comments

=== modified file 'qml/Dash/Dash.qml'
--- qml/Dash/Dash.qml	2015-02-17 08:26:20 +0000
+++ qml/Dash/Dash.qml	2015-04-08 07:52:07 +0000
@@ -178,7 +178,7 @@
         Binding {
             target: scopesList.scope
             property: "isActive"
-            value: bottomEdgeController.progress === 1
+            value: bottomEdgeController.progress === 1 && (Qt.application.state == Qt.ApplicationActive)
         }
 
         Connections {

=== modified file 'qml/Dash/GenericScopeView.qml'
--- qml/Dash/GenericScopeView.qml	2015-03-13 10:07:57 +0000
+++ qml/Dash/GenericScopeView.qml	2015-04-08 07:52:07 +0000
@@ -19,7 +19,6 @@
 import Utils 0.1
 import Unity 0.2
 import Dash 0.1
-import Powerd 0.1
 import "../Components"
 import "../Components/ListItems" as ListItems
 
@@ -105,7 +104,7 @@
     Binding {
         target: scope
         property: "isActive"
-        value: isCurrent && !subPageLoader.open && (Powerd.status === Powerd.On)
+        value: isCurrent && !subPageLoader.open && (Qt.application.state == Qt.ApplicationActive)
     }
 
     UnitySortFilterProxyModel {