Merge lp:~unity-api-team/unity-scopes-shell/today-scope-crash into lp:unity-scopes-shell

Proposed by Pete Woods
Status: Superseded
Proposed branch: lp:~unity-api-team/unity-scopes-shell/today-scope-crash
Merge into: lp:unity-scopes-shell
Prerequisite: lp:~unity-api-team/unity-scopes-shell/geoip-thread-affinity-fix
Diff against target: 28 lines (+8/-0)
2 files modified
src/Unity/categories.cpp (+6/-0)
src/Unity/categories.h (+2/-0)
To merge this branch: bzr merge lp:~unity-api-team/unity-scopes-shell/today-scope-crash
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+242206@code.launchpad.net

This proposal supersedes a proposal from 2014-11-19.

This proposal has been superseded by a proposal from 2014-11-20.

Commit message

Fix today scope crash

Description of the change

Fix today scope crash

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Yes, it definately makes sense! +1

review: Approve
131. By Pete Woods

Fix thread affinity in GeoIp

132. By Pete Woods

Add destructor for Categories and clear data models

133. By Pete Woods

Explanation

Unmerged revisions

133. By Pete Woods

Explanation

132. By Pete Woods

Add destructor for Categories and clear data models

131. By Pete Woods

Fix thread affinity in GeoIp

130. By Paweł Stołowski

Merged trunk.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Unity/categories.cpp'
2--- src/Unity/categories.cpp 2014-08-05 23:33:32 +0000
3+++ src/Unity/categories.cpp 2014-11-20 14:04:41 +0000
4@@ -306,6 +306,12 @@
5 {
6 }
7
8+Categories::~Categories()
9+{
10+ m_categories.clear();
11+ m_categoryResults.clear();
12+}
13+
14 int Categories::rowCount(const QModelIndex& parent) const
15 {
16 Q_UNUSED(parent);
17
18=== modified file 'src/Unity/categories.h'
19--- src/Unity/categories.h 2014-07-17 15:44:03 +0000
20+++ src/Unity/categories.h 2014-11-20 14:04:41 +0000
21@@ -43,6 +43,8 @@
22 public:
23 explicit Categories(QObject* parent = 0);
24
25+ ~Categories();
26+
27 QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;
28 int rowCount(const QModelIndex& parent = QModelIndex()) const override;
29

Subscribers

People subscribed via source and target branches

to all changes: