Code review comment for lp:~unity-api-team/indicator-network/modeminfo

Antti Kaijanmäki (kaijanmaki) wrote :

> Seems to be a little better now, but after a few tries of rebooting phone and
> unlocking I got this:
>
> This is after unlocking. Note missing text & disabled signal icon in panel.
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim8.png

OK. seems your phone gets an unknown state from networkregistration and unfortunately the unknown case was accidentally clearing the connectivity-icon instead of status icon. Fixed now.

> After restarting indicator-network.
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim9.png
>
> The state text should never be empty. If it's in an unknown state, it should
> say "Unknown".

Agreed and fixed.

« Back to merge proposal