Code review comment for lp:~unity-api-team/indicator-network/modeminfo

> On Mako
>
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim1.png
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim2.png
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim3.png
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim4.png
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim5.png
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim6.png
> https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim7.png
>
> locked_sim1.png) this is how it comes up on boot. looks ok
> locked_sim2.png) after unlocking phone. Note it still says "SIM Locked"
> locked_sim3.png) restart indicator-network
> locked_sim4.png) called the phone when it was in state 3. rejected
> locked_sim5.png) restart indicator-network. called phone again. Can see the
> notification for accepting call, but see is still "Offline" & no strength icon
> locked_sim6.png) restarted phone. came up without a locked sim icon in panel
> as in 1
> locked_sim7.png) resarted again and unlocked. finally went into searching,
> then picked up a network.

Thank you for in-depth testing!

I nailed a couple of bugs and hopefully all of the above problems are now solved.

> But it doesn't match with the designs you provided
> where there is the phone number above the carrier.

The phone number is not always available. We need to investigate a bit more to figure out what additional information to have in there.

> There is no way to tell the
> sims apart if connected on same network.

Agreed.

I added default SIM identifiers (SIM 1, SIM 2) which are visible when using a dual sim device.

on a single sim device there is no reason to show the identifier as there is only one sim.