Code review comment for lp:~unity-api-team/indicator-network/modeminfo

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

On Mako

https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim1.png
https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim2.png
https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim3.png
https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim4.png
https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim5.png
https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim6.png
https://dl.dropboxusercontent.com/u/85539674/locked_sim/locked_sim7.png

locked_sim1.png) this is how it comes up on boot. looks ok
locked_sim2.png) after unlocking phone. Note it still says "SIM Locked"
locked_sim3.png) restart indicator-network
locked_sim4.png) called the phone when it was in state 3. rejected
locked_sim5.png) restart indicator-network. called phone again. Can see the notification for accepting call, but see is still "Offline" & no strength icon
locked_sim6.png) restarted phone. came up without a locked sim icon in panel as in 1
locked_sim7.png) resarted again and unlocked. finally went into searching, then picked up a network. But it doesn't match with the designs you provided where there is the phone number above the carrier. There is no way to tell the sims apart if connected on same network.

/usr/share/ofono/scripts/list-modems output for each state.
1) http://paste.ubuntu.com/7969273/
2) http://paste.ubuntu.com/7969275/
3) http://paste.ubuntu.com/7969276/
4) http://paste.ubuntu.com/7969279/
5) http://paste.ubuntu.com/7969280/
6) can't reproduce
7) http://paste.ubuntu.com/7969282/

review: Needs Fixing

« Back to merge proposal