click

Merge lp:~unity-api-team/click/scope-facing-apis into lp:click/devel

  1. scope-facing-apis
  2. Merge into devel
Proposed by Pete Woods
Status: Merged
Approved by: Colin Watson
Approved revision: 517
Merged at revision: 517
Proposed branch: lp:~unity-api-team/click/scope-facing-apis
Merge into: lp:click/devel
Diff against target: 29 lines (+11/-0)
1 file modified
click/chroot.py (+11/-0)
To merge this branch: bzr merge lp:~unity-api-team/click/scope-facing-apis
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Colin Watson Approve
Michael Vogt Pending
Review via email: mp+233974@code.launchpad.net

This proposal supersedes a proposal from 2014-09-05.

Commit message

Add scope-facing APIs to chroot build

Description of the change

Add scope-facing APIs to chroot build

To post a comment you must log in.
Revision history for this message
Pete Woods (pete-woods) wrote : Posted in a previous version of this proposal

I've tried creating a new chroot from this, and it successfully builds the new scopes template from the SDK: https://code.launchpad.net/~pete-woods/qtcreator-plugin-ubuntu/new-scope-template/+merge/233218

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:444
http://jenkins.qa.ubuntu.com/job/click-ci/17/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/17
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/17
        deb: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/17/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/17/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Vogt (mvo) wrote : Posted in a previous version of this proposal

This looks good, however there are two libraries that are in universe right now, I'm not sure what our policy is here and if we need a MIR (Colin will know).

Revision history for this message
Colin Watson (cjwatson) wrote : Posted in a previous version of this proposal

We don't need an MIR for these at this point - we have other things in universe.

Revision history for this message
Michael Vogt (mvo) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) wrote : Posted in a previous version of this proposal

isn't this supposed to target the staging/devel click?

Revision history for this message
Colin Watson (cjwatson) wrote : Posted in a previous version of this proposal

Er, yes, please resubmit this against lp:click/devel.

review: Needs Resubmitting
Revision history for this message
Pete Woods (pete-woods) wrote :

Done!

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:517
http://jenkins.qa.ubuntu.com/job/click-devel-ci/62/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-utopic-amd64-ci/64
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-utopic-armhf-ci/62
        deb: http://jenkins.qa.ubuntu.com/job/click-devel-utopic-armhf-ci/62/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-utopic-i386-ci/62

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-devel-ci/62/rebuild

review: Approve (continuous-integration)
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'click/chroot.py'
2--- click/chroot.py 2014-08-06 22:38:57 +0000
3+++ click/chroot.py 2014-09-09 18:07:35 +0000
4@@ -77,6 +77,11 @@
5 ],
6 "ubuntu-sdk-14.04": [
7 "cmake",
8+ "google-mock:TARGET",
9+ "libboost1.55-dev:TARGET",
10+ "libjsoncpp-dev:TARGET",
11+ "libprocess-cpp-dev:TARGET",
12+ "libproperties-cpp-dev:TARGET",
13 "libqt5svg5-dev:TARGET",
14 "libqt5webkit5-dev:TARGET",
15 "libqt5xmlpatterns5-dev:TARGET",
16@@ -99,7 +104,13 @@
17 ],
18 "ubuntu-sdk-14.10": [
19 "cmake",
20+ "google-mock:TARGET",
21+ "libboost1.55-dev:TARGET",
22 "libcontent-hub-dev:TARGET",
23+ "libjsoncpp-dev:TARGET",
24+ "libnet-cpp-dev:TARGET",
25+ "libprocess-cpp-dev:TARGET",
26+ "libproperties-cpp-dev:TARGET",
27 "libqt5keychain0:TARGET",
28 "libqt5sensors5-dev:TARGET",
29 "libqt5svg5-dev:TARGET",

Subscribers

People subscribed via source and target branches

to all changes: