Code review comment for lp:~unity-api-team/click/drop_packagekit

Well, I'd like to be on record that I think this is a bad idea, because in my experience this kind of divergence always lasts much longer than originally intended, so I'd prefer not to change my vote from Disapprove. However, it's up to you if you want to land it over my objections, since I'm not in charge of this project any more.

On a technical level, this branch is incorrect because it will break dual landings: it will have the effect of disabling PK even if an appropriate version of PK is available in the archive. To fix this, I would suggest restoring the build-dependency on libpackagekit-glib2-dev, but changing it to read "libpackagekit-glib2-dev (>= 0.8.10) | base-files, libpackagekit-glib2-dev (<< 1.0.0)" instead.

Please also fix the indentation so that it isn't confusing (i.e. don't have inner levels at the same level as outer levels). It would be simplest for it to just read:

  if dpkg --compare-versions "$packagekit_version" ge 0.8.10 && \
     dpkg --compare-versions "$packagekit_version" lt 1.0.0; then
          echo yes
  else
          echo no
  fi