Merge lp:~unity-2d-team/unity-2d/update-launcher-pips-shell into lp:~unity-2d-team/unity-2d/unity-2d-shell

[Lohith D Shivamurthy]

[shell][launcher] launcher pips indicate whether application windows belongs to current workspace or not

[Michał Sawicz (saviq)]

Hey, the pips weren't updating when I changed workspaces, just when I launched / closed apps, can you please verify it behaves as expected when switching workspaces?

review: Needs Fixing (functional)

[lp:~unity-2d-team/unity-2d/update-launcher-pips-shell]

924. By Lohith D Shivamurthy on 2012-01-24

[shell][launcher] update pips when the user workspace changed. Also added tests for the same

[Michał Sawicz (saviq)]

Hey, any reason you're not using the TmpWindow class?

review: Needs Information

[Gerry Boland (gerboland)]

Yeah, since we run tests with a Terminal open already, he needed to start testing with a non-running application, checking no pips, run the app, check pip, etc.

[Michał Sawicz (saviq)]

Maybe take a look at autohide_show_tests.rb:549 then for a way to find a non-running app and use that instead?

review: Needs Fixing

[Lohith D Shivamurthy (dyams)]

Hey, The test application should take some parameter to identiy its xid accurately. In this case, a unique title is set to test application and then later we find the xid for that window.

[Michał Sawicz (saviq)]

OK then, lets merge that now and once we have a better way to test these lets revisit, can you please add a FIXME in the tests? I'm simply wary of the test being unreliable if you pre-launch xman anywhere.

review: Needs Fixing

[Michał Sawicz (saviq)]

review: Approve

[Michał Sawicz (saviq)]

* what's the use of updateWindowWorkspaceChanged()? Can't you just emit the signal from the callback function?
* there's a tab instead of spaces in unity2ddeclarativeview.cpp:48
* updatePipSource updates both the source and pip count, please rename to updatePips
* pipSource should not be bound to updatePipSource, as it doesn't return anything - make it use the default value initially and the Connections will take care of updating it later
* there are tabs instead of spaces in LauncherList.qml:306
* change the puts() to comments in test startup and shutdown
* drop unneeded comment in test setup
* you have extra lines in test descriptions, please drop the lines only containing an asterisk
* Post-Conditions should not contain stuff that happens in teardown anyway, please drop the "Reset the current..." entries there
* again, tabs instead of spaces in the tests file
* test comments mentions calculator, please fix
* please don't "reuse" windows between tests as this will prevent running just one single test
* typos in "Test steps" - "reused", not "resued"
* typo in "Test steps" for "Update launcher pips to indicate an app with two windows on two different workspaces" - "along", not "alogn"
* typo in "Test steps" for "Update launcher pips to indicate an app completely belonging to different workspace." - missing "e" in "differnt"
* in some test objectives you say "Check for...", in others "Update...", please be consistent

review: Needs Fixing

[lp:~unity-2d-team/unity-2d/update-launcher-pips-shell]

925. By Lohith D Shivamurthy on 2012-01-24

[shell][launcher] Review comments fixed

926. By Lohith D Shivamurthy on 2012-01-25

[shell][launcher] Added a FIXME to choose a better test application

[Michał Sawicz (saviq)]

Gerry please take a look at the tests if you will.

And Gerry, Lohith some more things I'm not certain about:

1) the workspace-changed signals are connected in setIconGeometry? doesn't seem like the right place to do so?
2) shouldn't we also connect to workspace-changed signal in windowAdded()
3) do we really need to cast user_data to LauncherApplication*?

Please rename the callback to onWindowWorkspaceChanged

review: Needs Fixing

[lp:~unity-2d-team/unity-2d/update-launcher-pips-shell]

927. By Lohith D Shivamurthy on 2012-01-26

[shell][launcher] windows signal connection is moved to separate method

928. By Lohith D Shivamurthy on 2012-01-26

[shell] merge with trunk

[Michał Sawicz (saviq)]

You forgot:
* Please rename the callback to onWindowWorkspaceChanged

Please also fix the style in LauncherList.qml:292, move setIconGeometry() down one line.
There's also an extra blank line in launcherapplication.cpp:513

I'm not completely sure us going through QML just to proxy onRunningChanged() back into C++ is needed or required :/ Gerry, I'd like your opinion on that.

I'm not GObject-savvy enough to know whether we should disconnect from the workspace-changed signal when the window is removed / application stopped?

review: Needs Fixing

[Gerry Boland (gerboland)]

Functional problems:
1. I find when I launch shell, with existing applications open, that the pips are incorrect (they're all filled). Once I start navigating workspaces, the pips are corrected.

2. Set an application window to be "Always on Visible Workspace" (from window menu) - then its pips are always unfilled.

review: Needs Fixing

[lp:~unity-2d-team/unity-2d/update-launcher-pips-shell]

929. By Lohith D Shivamurthy on 2012-01-26

[launcher] update pips as soon as loading the launcher is completed

930. By Lohith D Shivamurthy on 2012-01-26

[launcher] Consider 'always on visible workspace' windows as always in the current workspace

[Gerry Boland (gerboland)]

Nice, those functional problems have been fixed.

Please update the tests to use $SUT.execute_shell_command

There is also a stray blank line in void LauncherApplication::connectWindowSignals() that you can remove.

And
+ onRunningChanged: { setIconGeometry()
+ item.connectWindowSignals()
+ }
is formatted strangely.

Fix those & I think we're good :)

review: Needs Fixing

[lp:~unity-2d-team/unity-2d/update-launcher-pips-shell]

931. By Lohith D Shivamurthy on 2012-01-26

[launcher] use sut global object, remove local object

932. By Lohith D Shivamurthy on 2012-01-26

[launcher] Replace 'system' with execute_shell_command

933. By Lohith D Shivamurthy on 2012-01-26

[launcher] remove extra line in cpp and add one line in qml

934. By Lohith D Shivamurthy on 2012-01-26

[launcher] replace 'CB' suffix with 'on' prefix for the callback

[Michał Sawicz (saviq)]

Yup, looks good!

review: Approve

=== modified file 'libunity-2d-private/src/launcherapplication.cpp'
--- libunity-2d-private/src/launcherapplication.cpp	2012-01-18 11:50:32 +0000
+++ libunity-2d-private/src/launcherapplication.cpp	2012-01-26 17:12:24 +0000
@@ -505,10 +505,36 @@
 }
 
 void
+LauncherApplication::connectWindowSignals()
+{
+    if (m_application == NULL || m_application->running() == false) {
+        return;
+    }
+
+    QScopedPointer<BamfUintList> xids(m_application->xids());
+    int size = xids->size();
+    if (size < 1) {
+        return;
+    }
+
+    WnckScreen* screen = wnck_screen_get_default();
+    wnck_screen_force_update(screen);
+
+    for (int i = 0; i < size; ++i) {
+        WnckWindow* window = wnck_window_get(xids->at(i));
+        g_signal_connect(G_OBJECT(window), "workspace-changed",
+            G_CALLBACK(LauncherApplication::onWindowWorkspaceChanged), this);
+    }
+}
+
+void
 LauncherApplication::onWindowAdded(BamfWindow* window)
 {
     if (window != NULL) {
         windowAdded(window->xid());
+        WnckWindow* wnck_window = wnck_window_get(window->xid());
+        g_signal_connect(G_OBJECT(wnck_window), "workspace-changed",
+             G_CALLBACK(LauncherApplication::onWindowWorkspaceChanged), this);
     }
 }
 
@@ -599,6 +625,11 @@
 LauncherApplication::windowCountOnCurrentWorkspace()
 {
     int windowCount = 0;
+
+    if (!m_application) {
+        return windowCount;
+    }
+
     WnckWorkspace *current = wnck_screen_get_active_workspace(wnck_screen_get_default());
 
     QScopedPointer<BamfWindowList> windows(m_application->windows());
@@ -620,9 +651,13 @@
             }
         }
 
-        WnckWorkspace *workspace = wnck_window_get_workspace(wnck_window);
-        if (workspace == current) {
+        if (wnck_window_is_pinned(wnck_window)) {
             windowCount++;
+        } else {
+            WnckWorkspace *workspace = wnck_window_get_workspace(wnck_window);
+            if (workspace == current) {
+                windowCount++;
+            }
         }
     }
     return windowCount;
@@ -937,6 +972,18 @@
     } 
 }
 
+bool
+LauncherApplication::belongsToDifferentWorkspace()
+{
+    int totalWindows = windowCount();
+    int windowsInCurrentWorkspace = windowCountOnCurrentWorkspace();
+    if (totalWindows > 0 && windowsInCurrentWorkspace == 0) {
+        return true;
+    }
+
+    return false;
+}
+
 void
 LauncherApplication::onIndicatorMenuUpdated()
 {
@@ -1053,4 +1100,11 @@
     setDynamicQuicklistImporter(newOwner);
 }
 
+void
+LauncherApplication::onWindowWorkspaceChanged(WnckWindow *window, gpointer user_data)
+{
+    Q_UNUSED(window);
+    ((LauncherApplication*)user_data)->windowWorkspaceChanged();
+}
+
 #include "launcherapplication.moc"

=== modified file 'libunity-2d-private/src/launcherapplication.h'
--- libunity-2d-private/src/launcherapplication.h	2012-01-13 15:05:44 +0000
+++ libunity-2d-private/src/launcherapplication.h	2012-01-26 17:12:24 +0000
@@ -104,6 +104,8 @@
     Q_INVOKABLE virtual void launchNewInstance();
 
     Q_INVOKABLE virtual void createMenuActions();
+    Q_INVOKABLE virtual bool belongsToDifferentWorkspace();
+    Q_INVOKABLE void connectWindowSignals();
 
     void updateOverlaysState(const QString& sender, const QMap<QString, QVariant>& properties);
 
@@ -174,6 +176,8 @@
     bool updateOverlayState(const QMap<QString, QVariant>& properties,
                             const QString& propertyName, T* member);
 
+    static void onWindowWorkspaceChanged(WnckWindow *window, gpointer user_data);
+
     QString m_dynamicQuicklistPath;
     QScopedPointer<DBusMenuImporter> m_dynamicQuicklistImporter;
     QDBusServiceWatcher* m_dynamicQuicklistServiceWatcher;

=== modified file 'libunity-2d-private/src/launcheritem.cpp'
--- libunity-2d-private/src/launcheritem.cpp	2011-07-29 13:49:34 +0000
+++ libunity-2d-private/src/launcheritem.cpp	2012-01-26 17:12:24 +0000
@@ -87,6 +87,12 @@
 }
 
 bool
+LauncherItem::belongsToDifferentWorkspace()
+{
+    return false;
+}
+
+bool
 LauncherItem::progressBarVisible() const
 {
     return false;

=== modified file 'libunity-2d-private/src/launcheritem.h'
--- libunity-2d-private/src/launcheritem.h	2011-07-29 13:49:34 +0000
+++ libunity-2d-private/src/launcheritem.h	2012-01-26 17:12:24 +0000
@@ -79,6 +79,7 @@
     Q_INVOKABLE virtual void activate() = 0;
     Q_INVOKABLE virtual void createMenuActions() = 0;
     Q_INVOKABLE virtual void launchNewInstance();
+    Q_INVOKABLE virtual bool belongsToDifferentWorkspace();
 
 protected:
     LauncherContextualMenu* m_menu;
@@ -100,6 +101,7 @@
     void counterChanged(int);
     void emblemVisibleChanged(bool);
     void emblemChanged(QString);
+    void windowWorkspaceChanged();
 
 public Q_SLOTS:
     /* Default implementation of drag’n’drop handling, should be overridden in

=== modified file 'libunity-2d-private/src/unity2ddeclarativeview.cpp'
--- libunity-2d-private/src/unity2ddeclarativeview.cpp	2012-01-19 15:06:15 +0000
+++ libunity-2d-private/src/unity2ddeclarativeview.cpp	2012-01-26 17:12:24 +0000
@@ -269,6 +269,7 @@
 void Unity2DDeclarativeView::onActiveWorkspaceChanged() 
 {
     m_last_focused_window = None;
+    Q_EMIT activeWorkspaceChanged();
 }
 
 #include <unity2ddeclarativeview.moc>

=== modified file 'libunity-2d-private/src/unity2ddeclarativeview.h'
--- libunity-2d-private/src/unity2ddeclarativeview.h	2012-01-11 20:33:19 +0000
+++ libunity-2d-private/src/unity2ddeclarativeview.h	2012-01-26 17:12:24 +0000
@@ -45,6 +45,7 @@
     void transparentBackgroundChanged(bool);
     void globalPositionChanged(QPoint);
     void shown();
+    void activeWorkspaceChanged();
 
 protected:
     void setupViewport();

=== modified file 'shell/launcher/LauncherItem.qml'
--- shell/launcher/LauncherItem.qml	2012-01-19 14:40:22 +0000
+++ shell/launcher/LauncherItem.qml	2012-01-26 17:12:24 +0000
@@ -156,7 +156,7 @@
         Repeater {
             model: item.pips
             delegate: Image {
-                objectName: "pips"
+                objectName: "pips-" + index
                 /* FIXME: It seems that when the image is created (or re-used) by the Repeater
                    for a moment it doesn't have any parent, and therefore warnings are
                    printed for the following two anchor assignements. This fixes the

=== modified file 'shell/launcher/LauncherList.qml'
--- shell/launcher/LauncherList.qml	2012-01-19 14:40:22 +0000
+++ shell/launcher/LauncherList.qml	2012-01-26 17:12:24 +0000
@@ -92,6 +92,16 @@
             }
         }
 
+        function updatePips() {
+            if (item.belongsToDifferentWorkspace()) {
+                launcherItem.pips = 1
+                launcherItem.pipSource = "launcher/artwork/launcher_arrow_outline_ltr.png";
+            } else {
+                launcherItem.pips = Math.min(item.windowCount, 3)
+                launcherItem.pipSource = ("launcher/artwork/launcher_" + ((pips <= 1) ? "arrow" : "pip") + "_ltr.png")
+            }
+        }
+
         Accessible.name: accessibleDescription()
         name: item.name
 
@@ -279,7 +289,10 @@
             PropertyAction { target: launcherItem; property: "ListView.delayRemove"; value: false }
         }
 
-        onRunningChanged: setIconGeometry()
+        onRunningChanged: {
+            setIconGeometry()
+            item.connectWindowSignals()
+        }
         /* Note: this doesn’t work as expected for the first favorite
            application in the list if it is already running when the
            launcher is started, because its y property doesn’t change.
@@ -292,6 +305,8 @@
             onWindowAdded: item.setIconGeometry(x + declarativeView.globalPosition.x,
                                                 y + declarativeView.globalPosition.y,
                                                 width, height, xid)
+            onWindowCountChanged: updatePips()
+            onWindowWorkspaceChanged: updatePips()
             /* Not all items are applications. */
             ignoreUnknownSignals: true
         }
@@ -335,5 +350,11 @@
                 }
             }
         }
+
+        Connections {
+            target: declarativeView
+            onActiveWorkspaceChanged: updatePips()
+        }
+        Component.onCompleted: updatePips()
     }
 }

=== added file 'shell/launcher/artwork/launcher_arrow_outline_ltr.png'
Binary files shell/launcher/artwork/launcher_arrow_outline_ltr.png	1970-01-01 00:00:00 +0000 and shell/launcher/artwork/launcher_arrow_outline_ltr.png	2012-01-26 17:12:24 +0000 differ
=== added file 'tests/launcher/update_pips_tests.rb'
--- tests/launcher/update_pips_tests.rb	1970-01-01 00:00:00 +0000
+++ tests/launcher/update_pips_tests.rb	2012-01-26 17:12:24 +0000
@@ -0,0 +1,315 @@
+#!/usr/bin/env ruby1.8
+=begin
+/*
+ * This file is part of unity-2d
+ *
+ * Copyright 2011 Canonical Ltd.
+ *
+ * Authors:
+ * - Lohith DS <[e-mail]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+=end
+
+require '../run-tests.rb' unless $INIT_COMPLETED
+require 'xdo/xwindow'
+require 'xdo/keyboard'
+require 'xdo/mouse'
+require 'timeout'
+require 'tmpdir'
+
+def open_window()
+    # FIXME : Need to choose a better test application in future?
+    window_id = -1
+    o =  [('a'..'z'),('A'..'Z')].map{|i| i.to_a}.flatten;
+    title_string  =  (0..50).map{ o[rand(o.length)]  }.join;
+    if (@@title_string.empty?)
+        @@title_string = title_string
+    end
+    # Open xman with random title
+    $SUT.execute_shell_command("xman -geometry 300x90+100+100 -title #{title_string}", :detached => true)
+    Timeout.timeout(30){ window_id = XDo::XWindow.wait_for_window(title_string)}
+    Kernel.raise(SystemCallError, "Unable to open xman") if window_id == -1
+    return XDo::XWindow.new(window_id)
+end
+
+def change_window_workspace(xid)
+    new_workspace = 0
+    if xid.desktop > 0
+        new_workspace=0
+    else
+        new_workspace=1
+    end
+
+    xid.desktop=new_workspace
+    verify_true(3, 'Change window workspace failed') {
+        xid.desktop==new_workspace
+    }
+end
+
+def reset_current_workspace
+    XDo::XWindow.desktop=@@current_workspace
+    verify_true(TIMEOUT, 'Reset active workspace failed') {
+        XDo::XWindow.desktop==@@current_workspace
+    }
+end
+
+def change_user_workspace
+    new_workspace = 0
+    if @@current_workspace > 0
+        new_workspace = 0
+    else
+        new_workspace = 1
+    end
+
+    XDo::XWindow.desktop=new_workspace
+    verify_true(TIMEOUT, 'Change user workspace failed') {
+        XDo::XWindow.desktop==new_workspace
+    }
+end
+
+def close_all_test_windows
+    @@xid_list.each {
+        |xid|
+        if (xid.exists?)
+            xid.close!
+        end
+    }
+end
+
+############################# Test Suite #############################
+context "Launcher pips tests" do
+  # Run once at the beginning of this test suite
+  startup do
+    $SUT.execute_shell_command 'killall unity-2d-launcher'
+    $SUT.execute_shell_command 'killall unity-2d-shell'
+    $SUT.execute_shell_command 'killall unity-2d-shell'
+
+    # Minimize all windows
+    XDo::XWindow.toggle_minimize_all
+
+    @number_of_workspaces = XDo::XWindow.desktop_num
+    @reset_num_workspaces = false
+    if @number_of_workspaces < 2
+        # Setting number of workspaces to minimum(two) to enable the test suite
+        XDo::XWindow.desktop_num = 2
+        @reset_num_workspaces = true
+    end
+
+    $SUT.execute_shell_command 'killall xman'
+    @@current_workspace = XDo::XWindow.desktop
+    @@xid_list=Array.new
+
+  end
+  
+  # Run once at the end of this test suite
+  shutdown do
+    if @reset_num_workspaces == true
+        # Resetting number of workspaces to " + @number_of_workspaces.to_s
+        XDo::XWindow.desktop_num=@number_of_workspaces
+    end
+  end
+
+  # Run before each test case begins
+  setup do
+    # Execute the application 
+    @app = $SUT.run( :name => UNITY_2D_SHELL,
+    		         :arguments => "-testability", 
+    		         :sleeptime => 2 )
+    @@title_string = ""
+  end
+
+  # Run after each test case completes
+  teardown do
+    close_all_test_windows
+    reset_current_workspace
+    system "pkill -nf unity-2d-shell"
+  end
+
+    #####################################################################################
+    # Test cases
+
+    # Test case objectives:
+    #   * Check pips are updated properly when the app is in current workspace
+    # Pre-conditions
+    #   * This test case assumes that the test app will have only one window
+    #   * For eg, xman is choosen
+    #   * To ensure there is no xman windows running, kill all the xman windows if any
+    # Test steps
+    #   * Open a xman window
+    #   * Verify the launcher tile pip image matches with the expected one
+    # Post-conditions
+    #   * None
+    # References
+    #   * lp:#883172
+    test "Check pips are updated properly when the app is in current workspace" do
+        xid = open_window()
+        @@xid_list << xid
+
+        expected_pip_image = 'image://blended/launcher/artwork/launcher_arrow_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, TIMEOUT, 'pip not matching with launcher_arrow_ltr.png'){
+             @app.Launcher() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+
+    # Test case objectives:
+    #   * Check pips are updated properly when the app is moved to different workspace
+    # Pre-conditions
+    #   * None
+    # Test steps
+    #   * Move the window to a different workspace
+    #   * Verify the launcher tile pip image matches with the expected one
+    # Post-conditions
+    #   * None
+    # References
+    #   * lp:#883172
+    test "Check pips are updated properly when the app is moved to different workspace" do
+        xid = open_window()
+        @@xid_list << xid
+
+        change_window_workspace(xid)
+
+        expected_pip_image = 'image://blended/launcher/artwork/launcher_arrow_outline_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, TIMEOUT, 'pip not matching with launcher_arrow_outline_ltr.png'){
+             @app.Launcher() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+
+    # Test case objectives:
+    #   * Check launcher pips to indicate an app with two windows each on two different workspaces
+    # Pre-conditions
+    #   * None
+    # Test steps
+    #   * Open another window along with first window from the first testcase.
+    #   * Verify the launcher tile pip images matches with the expected one
+    # Post-conditions
+    #   * None
+    # References
+    #   * lp:#883172
+    test "Check launcher pips to indicate an app with two windows each on two different workspaces" do
+        xid = open_window()
+        @@xid_list << xid
+        xid = open_window()
+        @@xid_list << xid
+
+        expected_pip_image = 'image://blended/launcher/artwork/launcher_pip_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, TIMEOUT, 'Pip not matching expected image launcher_pip_ltr.png'){
+             @app.Launcher() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+
+    # Test case objectives:
+    #   * Check launcher pips to indicate an app completely belonging to different workspace
+    # Pre-conditions
+    #   * None
+    # Test steps
+    #   * Move the second window too to a different workspace
+    #   * Verify the launcher tile pip image matches with the expected one
+    # Post-conditions
+    #   * None
+    # References
+    #   * lp:#883172
+    test "Check launcher pips to indicate an app completely belonging to different workspace" do
+        xid = open_window()
+        @@xid_list << xid
+        change_window_workspace(xid)
+
+        xid = open_window()
+        @@xid_list << xid
+        change_window_workspace(xid)
+
+        expected_pip_image = 'image://blended/launcher/artwork/launcher_arrow_outline_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, TIMEOUT, 'pip not matching expected image launcher_arrow_outline_ltr.png'){
+             @app.Launcher() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+
+    # Test case objectives:
+    #   * Check launcher pips when an app window is closed.
+    # Pre-conditions
+    #   * None
+    # Test steps
+    #   * Close one of the app windows and move the last window back to its original workspace
+    #   * Verify the launcher tile pip image matches with the expected one
+    # Post-conditions
+    #   * None
+    # References
+    #   * lp:#883172
+    test "Check launcher pips when an app window is closed" do
+        xid = open_window()
+        @@xid_list << xid
+        xid = open_window()
+        @@xid_list << xid
+
+        xid.close!
+        change_window_workspace(@@xid_list[0])
+
+        expected_pip_image = 'image://blended/launcher/artwork/launcher_arrow_outline_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, TIMEOUT, 'pip not matching expected image launcher_arrow_outline_ltr.png'){
+             @app.Launcher() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+
+    # Test case objectives:
+    #   * Check launcher pips to indicate when the user workspace changed
+    # Pre-conditions
+    #   * None
+    # Test steps
+    #   * Change the user workspace to other than app workspace
+    #   * Verify that the pips are updated properly
+    # Post-conditions
+    #   * None
+    # References
+    #   * lp:#883172
+    test "Check launcher pips to indicate when the user workspace changed" do
+        xid = open_window()
+        @@xid_list << xid
+
+        change_user_workspace
+
+        expected_pip_image = 'image://blended/launcher/artwork/launcher_arrow_outline_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, TIMEOUT, 'pip not matching expected image launcher_arrow_outline_ltr.png'){
+             @app.Launcher() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+end