Code review comment for lp:~unity-2d-team/unity-2d/unity-2d_enable-super-numkey-combo

Revision history for this message
Albert Astals Cid (aacid) wrote :

This is the heir of https://code.launchpad.net/~unity-2d-team/unity-2d/enable-super-numkey-combo/+merge/89883 that was rejected because was against unity-2d-shell instead of unity-2d

Copying here Michał's comments of what needs to be fixed.

The test is broken:
* if the launcher item is already in "running" state, the test won't really test anything
* if the app in question doesn't start within TIMEOUT, the test will fail even though the feature actually worked
* LibreOffice Impress, for example, doesn't go into "running" state before you actually create a slidedeck, so the test will fail in a clean environment every time
* the result of this test is a workspace cluttered with up to 10 new windows that aren't closed

review: Needs Fixing

« Back to merge proposal