Code review comment for lp:~unity-2d-team/unity-2d/shortcut-hint-overlay
Revision history for this message
| Michał Sawicz (saviq) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
> Hey, this looks like it could go into lp:unity-2d with minor modifications,
> and will reduce the diff when we actually go to merging shell into trunk,
> could you please have a MR against lp:unity-2d for this?
Actually that might not be worth it, since you don't have any fullscreen part of the UI with unity-2d, you'd have to hack up the dash to go fullscreen when the hint is supposed to show.
In that case I propose that we wait with merging this for the shell to be merged into trunk and then MR that change against trunk.