Merge lp:~unit193/ubuntu-release-upgrader/core-upgrades into lp:ubuntu-release-upgrader
| Status: | Merged |
|---|---|
| Merged at revision: | 2870 |
| Proposed branch: | lp:~unit193/ubuntu-release-upgrader/core-upgrades |
| Merge into: | lp:ubuntu-release-upgrader |
| Diff against target: |
62 lines (+20/-3) (has conflicts) 2 files modified
data/DistUpgrade.cfg (+10/-3) debian/changelog (+10/-0) Text conflict in debian/changelog |
| To merge this branch: | bzr merge lp:~unit193/ubuntu-release-upgrader/core-upgrades |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brian Murray | 2015-02-18 | Needs Information on 2015-02-19 | |
| Julien Lavergne (community) | 2015-02-18 | Approve on 2015-02-19 | |
| Simon Steinbeiß (community) | 2015-02-18 | Approve on 2015-02-19 | |
| Pasi Lallinaho (community) | community | 2015-02-18 | Approve on 2015-02-18 |
| Walter Lapchynski (community) | Approve on 2015-02-18 | ||
|
Review via email:
|
|||
Description of the Change
As it is now, if a user installs from the mini.iso and installs the xubuntu-core or lubuntu-core tasks, upon upgrade to the next release they end up getting the full *-desktop meta, this is not desired.
| Pasi Lallinaho (knome) wrote : | # |
To confirm that this change is ACK'd community-wise by the Xubuntu Project Lead today on IRC.
| Simon Steinbeiß (ochosi) wrote : | # |
I'll admit straight away that I don't know enough about the release-upgrader to be able to technically review this MR, I hope ubuntu-core-devs (or someone else more experienced with this) will take care of that part.
However, the change Unit193 describes above is what we want. Approving this as Xubuntu Project Lead.
| Julien Lavergne (gilir) wrote : | # |
Looks OK to me for the Lubuntu part. Thanks Unit193 :-)
(you just have to remove the >>>>>>> MERGE-SOURCE / <<<<<<< TREE if you want this to be merged :-))
| Brian Murray (brian-murray) wrote : | # |
Given that neither lubuntu-meta or xubuntu-meta includes ubuntu-
Could you provide some more information as to what problem you are trying to solve? One way to test your changes would be to run do-release-upgrade then cancel the upgrade after the dist upgrader tarball is downloaded, switch to whatever directory it is in /tmp/ e.g. /tmp/dist-
Finally, having lubuntu-core as a key dependency of itself seems rather redundant.
| Unit 193 (unit193) wrote : | # |
Sure, they don't seed that exact package, but both install and use it by installing update-manager as you can see http://
Both seeds/metas have a package and task called $flavor-core, so a user can optionally install only the minimal DE and default config. Currently when you upgrade, as expected $flavor-desktop is pulled in but as the user only wanted the bare minimum of defaults, this is highly undesired.
Yes, you are right there, I added Lubuntu support later after working out with the Xubuntu team how best to do it. Perhaps lubuntu-artwork or lubuntu-
Also, sorry for messing up the merge, seems there's some conflicts.
| Brian Murray (brian-murray) wrote : | # |
I've installed the xubuntu-core system from a Xubuntu 14.10 mini iso and agree those changes make sense. Could you sort out what makes sense for lubuntu-core? Otherwise, I'll just merge the Xubuntu only changes.
| Unit 193 (unit193) wrote : | # |
Not hearing back from them, I'd just go with lubuntu-artwork for lubuntu-core's keydeps or just drop it. Want me to try and fix it all up?
| Julien Lavergne (gilir) wrote : | # |
Sorry for the delay. The keydeps for lubuntu-core could be :
KeyDependencies
Thanks :-)
| Brian Murray (brian-murray) wrote : | # |
Okay, that sounds good to me now.
fwiw, this looks good to me. not the official lubuntu dev, but, i count for something. :)