Merge lp:~unifield-team/unifield-wm/sync-uf-2087-second-version into lp:unifield-wm/sync

Proposed by Quentin THEURET @Amaris
Status: Needs review
Proposed branch: lp:~unifield-team/unifield-wm/sync-uf-2087-second-version
Merge into: lp:unifield-wm/sync
Diff against target: 26 lines (+13/-3)
1 file modified
sync_client/orm.py (+13/-3)
To merge this branch: bzr merge lp:~unifield-team/unifield-wm/sync-uf-2087-second-version
Reviewer Review Type Date Requested Status
UniField Dev Team Pending
Review via email: mp+174156@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

339. By Quentin THEURET @Amaris

UF-2087 [FIX] Fix missing columns when filter o2m in sync. engine

338. By Quentin THEURET @Amaris

UF-2087 [FIX] Fix missing columns when filter o2m in sync. engine

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sync_client/orm.py'
2--- sync_client/orm.py 2013-07-10 14:34:06 +0000
3+++ sync_client/orm.py 2013-07-11 10:27:33 +0000
4@@ -331,9 +331,19 @@
5 synchronized_ids.extend(data_ids)
6
7 def filter_o2m(field_list):
8- return [(f, self._columns[f])
9- for f in field_list
10- if isinstance(self._columns[f], fields.one2many)]
11+ res = []
12+ for f in field_list:
13+ if f not in self._columns and \
14+ f in self._inherit_fields and \
15+ isinstance(self._inherit_fields[f][2], fields.one2many):
16+ res.append((f, self._inherit_fields[f][2]))
17+ elif f in self._columns and isinstance(self._columns[f], fields.one2many):
18+ res.append((f, self._columns[f]))
19+
20+ return res
21+# return [(f, self._columns[f])
22+# for f in field_list
23+# if f in self._columns and isinstance(self._columns[f], fields.one2many)]
24
25 if previous_values is None:
26 whole_fields = self._columns.keys()

Subscribers

People subscribed via source and target branches

to all changes: