Unifield Web

Merge lp:~unifield-team/unifield-web/utp-226 into lp:unifield-web

  1. utp-226
  2. Merge into trunk
Proposed by Matthieu Choplin
Status: Merged
Merged at revision: 4674
Proposed branch: lp:~unifield-team/unifield-web/utp-226
Merge into: lp:unifield-web
Diff against target: 13 lines (+2/-1)
1 file modified
addons/openerp/widgets/listgrid.py (+2/-1)
To merge this branch: bzr merge lp:~unifield-team/unifield-web/utp-226
Reviewer Review Type Date Requested Status
UniField Dev Team Pending
Review via email: mp+131411@code.launchpad.net
To post a comment you must log in.
lp:~unifield-team/unifield-web/utp-226 updated
4674. By <email address hidden>

[utp-226] according to this post: http://stackoverflow.com/questions/1549801/differences-between-isinstance-and-type-in-python isinstance seems better than comparing with type

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/widgets/listgrid.py'
2--- addons/openerp/widgets/listgrid.py 2012-10-22 13:25:35 +0000
3+++ addons/openerp/widgets/listgrid.py 2012-10-26 08:57:23 +0000
4@@ -344,7 +344,8 @@
5 values = dict(proxy.default_get(fields, ctx))
6
7 # update values according to domain
8- for (field, operator, value) in self.domain:
9+ list_of_tuple = [x for x in self.domain if isinstance(x, tuple)]
10+ for (field, operator, value) in list_of_tuple:
11 if field in fields:
12 if operator == '=':
13 values[field] = value

Subscribers

People subscribed via source and target branches

to all changes: