~ultimaker/ultimaker/+git/libSavitar:4.9

Last commit made on 2021-03-02
Get this branch:
git clone -b 4.9 https://git.launchpad.net/~ultimaker/ultimaker/+git/libSavitar

Branch merges

Branch information

Recent commits

fe88675... by Jaime van Kessel <email address hidden>

Merge branch 'update_deprecated_sip_functions' of https://github.com/StefanBruens/libSavitar

238d12b... by Remco Burema <email address hidden>

Merge pull request #32 from Ultimaker/CURA-7615_store_metadata

Store and preserve metadata

dce304c... by Ruben D

No longer always add Cura namespace before all metadata keys

There might be metadata entries that are not from Cura. Those should not get a namespace. The Cura front-end now needs to decide which metadata entries get a namespace and which don't. It should put a cura: namespace before any settings that it recognises.

Contributes to issue CURA-7615.

5f49889... by Ruben D

Don't filter metadata entries with unknown namespace

We'll just remove the cura: namespace then, to make Cura's settings still parse correctly.
This is a compromise. Basically this removes any 'cura:' namespace even though it is not a real namespace. This is not conformant to 3MF which would say that these names need to be preserved. This means that we'd need to pass on the 'cura:' namespace to Cura itself and let them handle it. However the Cura front-end code doesn't know the namespace aliases any more. It doesn't have access to them from there, since they are not actual XML namespaces but just a convention of the name attribute of metadata tags we have. The front-end doesn't even have access to the XML, let alone the namespaces in there for each tag.
The front-end needs to add the 'cura' namespace back if it recognises the name as a setting key, when writing the 3MF.

Contributes to issue CURA-7615.

342efd7... by Ruben D

Fix parser test

Due to the changed type of std::string plain values into MetadataEntry structs, we had to change a few things here.

Contributes to issue CURA-7615.

3dd4893... by Ruben D

Add overload for setting metadata directly from an entry

Saves having to unpack and re-pack these metadata entries on the user's side.

Contributes to issue CURA-7615.

0992bf3... by Ruben D

Implement parsing metadata properties from scene metadatagroup

Needs to be implemented here too.

Contributes to issue CURA-7615.

ac0139f... by Ruben D

Fix conversion of MetadataEntry inside dict to MetadataEntry

Previously it was converting to a Python string here due to copy-pasta failures.

Contributes to issue CURA-7615.

9b22559... by Ruben D

Also fill extra metadata properties for scene nodes

Missed this one at first.

Contributes to issue CURA-7615.

9c4ddd3... by Ruben D

Read and write type and preserve from metadata entries in 3MF docs

Contributes to issue CURA-7615.