~ultimaker/ultimaker/+git/libSavitar:4.10

Last commit made on 2021-05-10
Get this branch:
git clone -b 4.10 https://git.launchpad.net/~ultimaker/ultimaker/+git/libSavitar

Branch merges

Branch information

Recent commits

d1da2a7... by Konstantinos Karmas <email address hidden>

Merge pull request #33 from Ultimaker/use_FindPython3_if_available

CMake should sse find FindPython3 if available

53bfa0c... by Jelle Spijker <email address hidden>

Merge pull request #34 from Ultimaker/CURA-8146_Fix_getting_PyCapsule_error_on_import

CURA-8146: Fix getting PyCapsule error on import

83393f9... by Kostas Karmas <email address hidden>

Fix getting PyCapsule error on import

This fix overcomes the notorious `ValueError: PyCapsule_GetPointer called with incorrect name` that
we get if we do not import Arcus, Savitar, and pynest2d in cura_app.py (and other places) even if it
is not used.

All credits go to Rex Dieter for figuring that this missing flag was the issue.
https://src.fedoraproject.org/rpms/libarcus/pull-request/1#request_diff

CURA-8146

b69e82e... by "<email address hidden>" <jelle spijker>

Updated the devtoolset to version 8

e4f4584... by "<email address hidden>" <jelle spijker>

Allow cmake to use FindPython3 if possible

This allows us to use FindPython3 if the cmake version
is higher or equal to 3.12. Which allows a user to set
-DPython3_FIND_VIRTUALENV=ONLY such that the library
can be installed in a virtual environment (mostly
useful on Mac and Windows machines). This commit
doesn't break the current behavior of our CI machines.

fe88675... by Jaime van Kessel <email address hidden>

Merge branch 'update_deprecated_sip_functions' of https://github.com/StefanBruens/libSavitar

238d12b... by Remco Burema <email address hidden>

Merge pull request #32 from Ultimaker/CURA-7615_store_metadata

Store and preserve metadata

dce304c... by Ruben D

No longer always add Cura namespace before all metadata keys

There might be metadata entries that are not from Cura. Those should not get a namespace. The Cura front-end now needs to decide which metadata entries get a namespace and which don't. It should put a cura: namespace before any settings that it recognises.

Contributes to issue CURA-7615.

5f49889... by Ruben D

Don't filter metadata entries with unknown namespace

We'll just remove the cura: namespace then, to make Cura's settings still parse correctly.
This is a compromise. Basically this removes any 'cura:' namespace even though it is not a real namespace. This is not conformant to 3MF which would say that these names need to be preserved. This means that we'd need to pass on the 'cura:' namespace to Cura itself and let them handle it. However the Cura front-end code doesn't know the namespace aliases any more. It doesn't have access to them from there, since they are not actual XML namespaces but just a convention of the name attribute of metadata tags we have. The front-end doesn't even have access to the XML, let alone the namespaces in there for each tag.
The front-end needs to add the 'cura' namespace back if it recognises the name as a setting key, when writing the 3MF.

Contributes to issue CURA-7615.

342efd7... by Ruben D

Fix parser test

Due to the changed type of std::string plain values into MetadataEntry structs, we had to change a few things here.

Contributes to issue CURA-7615.