Merge ~ubuntustudio-dev/casper:main into casper:main

Proposed by Erich Eickmeyer
Status: Merged
Merged at revision: 0a993045fe157f43e07d1549be161a00943a453e
Proposed branch: ~ubuntustudio-dev/casper:main
Merge into: casper:main
Diff against target: 15 lines (+2/-2)
1 file modified
scripts/casper-bottom/15autologin (+2/-2)
Reviewer Review Type Date Requested Status
Dan Bungert (community) Approve
Ubuntu Installer Team Pending
Review via email: mp+473183@code.launchpad.net

Commit message

Switch Ubuntu Studio autologin to plasmax11

Description of the change

With the switch to Plasma 6, Ubuntu Studio's autologin no longer works as plasma.desktop is now plasmax11.desktop.

While the default session will be wayland after installation, during installation, for compatibility with virtual machines for testing reasons, an X11 session is desired.

To post a comment you must log in.
Revision history for this message
Dan Bungert (dbungert) wrote :

Hi Erich,

The change looks reasonable. I really know nothing though about plasma though. Is there benefit to just adding the new elif case and leaving the existing one, or do you have reason to be certain that plasma.desktop is not to be considered?

review: Needs Information
Revision history for this message
Erich Eickmeyer (eeickmeyer) wrote :

Considering plasma.desktop no longer exists in /usr/share/xsessions in oracular onward, it shouldn't be considered unless one wants to boot into the wayland session which, in my testing, is problematic on virtual machines, namely virtualbox. The only two sessions that exist are /usr/share/xsessions/plasmax11.desktop and /usr/share/wayland-sessions/plasma.desktop.

This could also have been accomplished with a symlink, but this method seemed to be more correct.

Revision history for this message
Dan Bungert (dbungert) wrote :

LGTM, sponsoring

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/scripts/casper-bottom/15autologin b/scripts/casper-bottom/15autologin
2index e66f06b..dea948c 100755
3--- a/scripts/casper-bottom/15autologin
4+++ b/scripts/casper-bottom/15autologin
5@@ -54,8 +54,8 @@ if [ -f /root/usr/bin/sddm ]; then
6 if [ -f /root/usr/share/xsessions/kubuntu-live-environment.desktop ]; then
7 sddm_session=kubuntu-live-environment.desktop
8 # Ubuntu Studio
9- elif [ -f /root/usr/share/xsessions/plasma.desktop ]; then
10- sddm_session=plasma.desktop
11+ elif [ -f /root/usr/share/xsessions/plasmax11.desktop ]; then
12+ sddm_session=plasmax11.desktop
13 # Lubuntu
14 elif [ -f /root/usr/share/xsessions/lubuntu-live-environment.desktop ]; then
15 sddm_session=lubuntu-live-environment.desktop

Subscribers

People subscribed via source and target branches