Merge ubuntu-manual-tests:remove_mention_of_recovery_key into ubuntu-manual-tests:main

Proposed by Tim Andersson
Status: Merged
Approved by: Brian Murray
Approved revision: 5ce77a9d943fe7da11b225f8812d1e22a87e844d
Merged at revision: 5ce77a9d943fe7da11b225f8812d1e22a87e844d
Proposed branch: ubuntu-manual-tests:remove_mention_of_recovery_key
Merge into: ubuntu-manual-tests:main
Diff against target: 61 lines (+3/-17)
2 files modified
definitions/basic_installation.xml (+1/-8)
testcases/image/1790_Install (entire disk with ZFS plus encryption) (+2/-9)
Reviewer Review Type Date Requested Status
Brian Murray Needs Information
Review via email: mp+453258@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I thought I overhead something about this in the war room but didn't hear the answer. Could you provide some details on why it is being removed?

review: Needs Information
Revision history for this message
Tim Andersson (andersson123) wrote :

xnox isn't sure if the recovery key is actually used in any way. He took a look at the code and I remember him saying he wasn't sure if the recovery key was being used at all, so I thought it best to remove mentions of it

Revision history for this message
Tim Andersson (andersson123) wrote :

merged and updated on the isotracker

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/definitions/basic_installation.xml b/definitions/basic_installation.xml
2index 3eec27f..85d66d3 100644
3--- a/definitions/basic_installation.xml
4+++ b/definitions/basic_installation.xml
5@@ -118,13 +118,6 @@
6 <dt>Click Continue</dt>
7 <dt>The "Choose a security key" slide opens</dt>
8 <dd>Enter your desired security key</dd>
9- <dt>Tick the "Enable recovery key" checkbox</dt>
10- <dd>Enter your desired recovery key</dd>
11- <dd>Click the downwards arrow icon, and click "Open" in the popup window</dd>
12- <dt>Open a terminal window and run the following commands:</dt>
13- <dd>cat /home/ubuntu/recovery.key</dd>
14- <dt>Verify the recovery key matches your inputted recovery key</dt>
15- <dt>Close the terminal window</dt>
16 <dt>Click on the 'Install Now' button</dt>
17 <dd>'Write the changes to disks' dialogue appears</dd>
18 <dt>Click Continue</dt>
19@@ -163,7 +156,7 @@
20 <dd>zpool import rpool</dd>
21 <dt>Check the output of the following command to see that rpool is imported:</dt>
22 <dd>zpool status -v</dd>
23- <dt>After entering the following command, enter your recovery key in the prompt:</dt>
24+ <dt>After entering the following command, enter your security key in the prompt:</dt>
25 <dd>cryptsetup luksOpen /dev/zvol/rpool/keystore keystore</dd>
26 <dt>Mount the keystore:</dt>
27 <dd>mkdir /mnt/keystore</dd>
28diff --git a/testcases/image/1790_Install (entire disk with ZFS plus encryption) b/testcases/image/1790_Install (entire disk with ZFS plus encryption)
29index 82231ae..684467c 100644
30--- a/testcases/image/1790_Install (entire disk with ZFS plus encryption)
31+++ b/testcases/image/1790_Install (entire disk with ZFS plus encryption)
32@@ -49,13 +49,6 @@
33 <dt>Click Continue</dt>
34 <dt>The "Choose a security key" slide opens</dt>
35 <dd>Enter your desired security key</dd>
36- <dt>Tick the "Enable recovery key" checkbox</dt>
37- <dd>Enter your desired recovery key</dd>
38- <dd>Click the downwards arrow icon, and click "Open" in the popup window</dd>
39- <dt>Open a terminal window and run the following commands:</dt>
40- <dd>cat /home/ubuntu/recovery.key</dd>
41- <dt>Verify the recovery key matches your inputted recovery key</dt>
42- <dt>Close the terminal window</dt>
43 <dt>Click on the 'Install Now' button</dt>
44 <dd>'Write the changes to disks' dialogue appears</dd>
45 <dt>Click Continue</dt>
46@@ -142,7 +135,7 @@
47 <dd>zpool import rpool</dd>
48 <dt>Check the output of the following command to see that rpool is imported:</dt>
49 <dd>zpool status -v</dd>
50- <dt>After entering the following command, enter your recovery key in the prompt:</dt>
51+ <dt>After entering the following command, enter your security key in the prompt:</dt>
52 <dd>cryptsetup luksOpen /dev/zvol/rpool/keystore keystore</dd>
53 <dt>Mount the keystore:</dt>
54 <dd>mkdir /mnt/keystore</dd>
55@@ -176,4 +169,4 @@
56 please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>. Please be sure to include
57 the bug number when you <a href="results#add_result">submit</a> your
58 result.</p>
59-
60+
61\ No newline at end of file

Subscribers

People subscribed via source and target branches

to all changes: