Merge ~ubuntu-server/ubuntu/+source/dpdk-testing:increasing-prio-for-proposed into ~ubuntu-server/ubuntu/+source/dpdk-testing:main

Proposed by Miriam España Acebal
Status: Merged
Merged at revision: 1c373c740e78042ee270c777d34395f86f388b84
Proposed branch: ~ubuntu-server/ubuntu/+source/dpdk-testing:increasing-prio-for-proposed
Merge into: ~ubuntu-server/ubuntu/+source/dpdk-testing:main
Diff against target: 17 lines (+6/-0)
1 file modified
test.sh (+6/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  Approve
Bryce Harrington Needs Information
Canonical Server Reporter Pending
Review via email: mp+451027@code.launchpad.net

Description of the change

Hi!

This is the change Christian made on the horsea machine to be sure that we test the proposed packages (option -P) in all series, since from Lunar and beyond, the proposed pocket is pinned with priority 100 instead the usual 500. More info in [1],[2] and [3] (thanks to Andreas and Athos for making me aware of this, and for the links)

In the log for Lunar on dpdk MRE log [4], you can see fetching the packages from lunar-proposed correctly.

[1] https://discourse.ubuntu.com/t/should-we-enable-proposed-by-default-with-lower-pin-priority/28580
[2] https://lists.ubuntu.com/archives/ubuntu-devel/2021-January/041324.html
[3] https://manpages.ubuntu.com/manpages/lunar/en/man5/apt_preferences.5.html
[4] https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/2026351/comments/9

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Hi Miriam,

I'm unclear on the review needs for this MP, and am wondering since it was filed a while ago if it is still relevant? If it is WIP or no longer needed, can you set the Status accordingly? Otherwise, if you do require review/acceptance from Christian maybe ping him on a chat channel to add his thoughts/directions here?

review: Needs Information
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This LGTM, and it worked in your eval - thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/test.sh b/test.sh
2index 0e51889..122187e 100755
3--- a/test.sh
4+++ b/test.sh
5@@ -395,6 +395,12 @@ tool_distupgrade() {
6 if [[ "${PROPOSED}" == "true" ]]; then
7 if ! grep -q proposed /etc/apt/sources.list; then
8 echo "deb ${ARCHIVEURL} ${RELEASE}-proposed restricted main multiverse universe" >> /etc/apt/sources.list
9+ cat <<EOF >/etc/apt/preferences.d/proposed-updates
10+# Configure apt to pull all from proposed
11+Package: *
12+Pin: release a=$(lsb_release -cs)-proposed
13+Pin-Priority: 510
14+EOF
15 fi
16 else
17 if grep -q proposed /etc/apt/sources.list; then

Subscribers

People subscribed via source and target branches

to all changes: