Merge ~ubuntu-server-dev/ubuntu/+source/ceph:xnox-groovy into ~ubuntu-server-dev/ubuntu/+source/ceph:ubuntu/groovy

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 034c07d7160237cd6de57e42723be7f1d2277832
Proposed branch: ~ubuntu-server-dev/ubuntu/+source/ceph:xnox-groovy
Merge into: ~ubuntu-server-dev/ubuntu/+source/ceph:ubuntu/groovy
Diff against target: 43 lines (+10/-3)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-2)
debian/rules (+1/-1)
Reviewer Review Type Date Requested Status
Chris MacNaughton (community) Approve
Christian Ehrhardt  Abstain
James Page Pending
Review via email: mp+387128@code.launchpad.net

This proposal supersedes a proposal from 2020-07-09.

Commit message

d/rules,control: Enable boost context usage on s390x, it should be working correctly now. (LP: #1694926)

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi xnox, Ceph would be under the Openstack Team, I added James as reviewer so that this MP is actually seen.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The default reviewer has no real job to do here - abstaining for "usd import team"

review: Abstain
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Looks good to me and support does seem to have landed in the Boost packages for s390x

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4960405..568de1f 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+ceph (15.2.3-0ubuntu2) UNRELEASED; urgency=medium
7+
8+ * d/rules,control: Enable boost context usage on s390x, it should be
9+ working correctly now. (LP: #1694926)
10+
11+ -- Dimitri John Ledkov <xnox@ubuntu.com> Thu, 09 Jul 2020 12:53:53 +0100
12+
13 ceph (15.2.3-0ubuntu1) groovy; urgency=medium
14
15 [ Chris MacNaughton ]
16diff --git a/debian/control b/debian/control
17index 2adb666..5570b3d 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -29,8 +29,8 @@ Build-Depends:
21 libblkid-dev (>= 2.17),
22 libboost-atomic-dev (>= 1.71.0),
23 libboost-chrono-dev (>= 1.71.0),
24- libboost-context-dev (>= 1.71.0) [!s390x !mips64el !ia64 !m68k !ppc64 !riscv64 !sh4 !sparc64 !x32],
25- libboost-coroutine-dev (>= 1.71.0) [!s390x !mips64el !ia64 !m68k !ppc64 !riscv64 !sh4 !sparc64 !x32],
26+ libboost-context-dev (>= 1.71.0) [!mips64el !ia64 !m68k !ppc64 !riscv64 !sh4 !sparc64 !x32],
27+ libboost-coroutine-dev (>= 1.71.0) [!mips64el !ia64 !m68k !ppc64 !riscv64 !sh4 !sparc64 !x32],
28 libboost-date-time-dev (>= 1.71.0),
29 libboost-iostreams-dev (>= 1.71.0),
30 libboost-program-options-dev (>= 1.71.0),
31diff --git a/debian/rules b/debian/rules
32index f0c7c8c..d1fa6fb 100755
33--- a/debian/rules
34+++ b/debian/rules
35@@ -76,7 +76,7 @@ ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
36 extraopts += -DBOOST_J=$(NUMJOBS)
37 endif
38
39-ifneq (,$(findstring $(DEB_HOST_ARCH),s390x mips64el ia64 m68k ppc64 riscv64 sh4 sparc64 x32))
40+ifneq (,$(findstring $(DEB_HOST_ARCH),mips64el ia64 m68k ppc64 riscv64 sh4 sparc64 x32))
41 # beast depends on libboost_{context,coroutine} which is not supported on various archs
42 extraopts += -DWITH_BOOST_CONTEXT=OFF
43 else

Subscribers

People subscribed via source and target branches

to all changes: