Merge ubuntu-cve-tracker:add-boilerplate-updates-using-scripts into ubuntu-cve-tracker:master

Proposed by Nishit Majithia
Status: Merged
Merge reported by: Nishit Majithia
Merged at revision: 43b3dcb2ce2066bdcffcd56c0f9b1b51da873946
Proposed branch: ubuntu-cve-tracker:add-boilerplate-updates-using-scripts
Merge into: ubuntu-cve-tracker:master
Diff against target: 33 lines (+6/-0)
2 files modified
scripts/release-cycle-new-overlay.py (+5/-0)
scripts/sync-from-eol.py (+1/-0)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Ubuntu Security Team Pending
Review via email: mp+444105@code.launchpad.net

Commit message

Add boilerplate update to scripts

 - update to release-cycle-new-overlay.py to add overlay into all
   boilerplates files
 - update to sync-from-eol.py to mark the boilerplate entry as eol

Description of the change

Testing has been done by going back to the 176dc807 commit (which is before the update to boilerplate code) and following the steps mentioned here: https://wiki.ubuntu.com/SecurityTeam/ReleaseCycle#LTS_Release_goes_to_ESM_status_checklist

It will update all boilerplate CVE files as expected

To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM.

review: Approve
Revision history for this message
Nishit Majithia (0xnishit) wrote :

Thanks

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/scripts/release-cycle-new-overlay.py b/scripts/release-cycle-new-overlay.py
2index db9108c..d2ed5db 100755
3--- a/scripts/release-cycle-new-overlay.py
4+++ b/scripts/release-cycle-new-overlay.py
5@@ -39,11 +39,16 @@ pkgs = source_map.load()
6 cves = glob.glob('%s/CVE-*' % cve_lib.active_dir)
7 cves += glob.glob('%s/CVE-*' % cve_lib.retired_dir)
8 cves += glob.glob('%s/CVE-*' % cve_lib.ignored_dir)
9+cves += glob.glob('%s/*' % cve_lib.boilerplates_dir)
10 if os.path.islink(cve_lib.embargoed_dir):
11 cves += glob.glob('%s/CVE-*' % cve_lib.embargoed_dir)
12 cves += glob.glob('%s/EMB-*' % cve_lib.embargoed_dir)
13
14 for filename in cves:
15+ # we don't want to edit symlinks as that will cause them to become
16+ # unsymlinked
17+ if os.path.islink(filename):
18+ continue;
19 cve = os.path.basename(filename)
20 cvedir = os.path.basename(os.path.dirname(filename))
21 try:
22diff --git a/scripts/sync-from-eol.py b/scripts/sync-from-eol.py
23index dd6d9eb..1ca612c 100755
24--- a/scripts/sync-from-eol.py
25+++ b/scripts/sync-from-eol.py
26@@ -47,6 +47,7 @@ if opt.whole:
27 pkgs = source_map.load(releases=[opt.release], skip_eol_releases=False)
28
29 cves = glob.glob('%s/CVE-*' % cve_lib.active_dir)
30+cves += glob.glob('%s/*' % cve_lib.boilerplates_dir)
31
32 if os.path.islink('embargoed'):
33 cves += glob.glob('embargoed/CVE-*')

Subscribers

People subscribed via source and target branches