Ubuntu UI Toolkit

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/unsetGuBeforeDefaultCheck into lp:ubuntu-ui-toolkit/staging

  1. unsetGuBeforeDefaultCheck
  2. Merge into staging
Proposed by Christian Dywan on 2015-05-21
Status: Merged
Approved by: Christian Dywan on 2015-05-22
Approved revision: 1515
Merged at revision: 1515
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/unsetGuBeforeDefaultCheck
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 11 lines (+1/-0)
1 file modified
tests/unit/tst_units/tst_units.cpp (+1/-0)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/unsetGuBeforeDefaultCheck
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-05-22
Tim Peeters 2015-05-21 Approve on 2015-05-21
Review via email: mp+259743@code.launchpad.net

Commit Message

Unset GRID_UNIT_PX before checking default value

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1515
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1779/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2907
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/507
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/509
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/509/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/506
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2493
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2905
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2905/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20682

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1779/rebuild

review: Needs Fixing (continuous-integration)
Tim Peeters (tpeeters) wrote :

thanks

review: Approve
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/unit/tst_units/tst_units.cpp'
2--- tests/unit/tst_units/tst_units.cpp 2013-02-05 17:10:20 +0000
3+++ tests/unit/tst_units/tst_units.cpp 2015-05-21 10:24:50 +0000
4@@ -32,6 +32,7 @@
5 }
6
7 void defaultGridUnit() {
8+ qputenv("GRID_UNIT_PX", "");
9 UCUnits units;
10 QCOMPARE(units.gridUnit(), 8.0f);
11 }

Subscribers

People subscribed via source and target branches