Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/textComponentsActiveFocus into lp:ubuntu-ui-toolkit/staging

Proposed by Christian Dywan on 2015-04-16
Status: Merged
Approved by: Zsombor Egri on 2015-04-16
Approved revision: 1480
Merged at revision: 1481
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/textComponentsActiveFocus
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 45 lines (+4/-4)
3 files modified
modules/Ubuntu/Components/TextArea.qml (+1/-1)
modules/Ubuntu/Components/TextField.qml (+1/-1)
modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml (+2/-2)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/textComponentsActiveFocus
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-04-16
Zsombor Egri (community) 2015-04-16 Approve on 2015-04-16
Review via email: mp+256495@code.launchpad.net

Commit Message

Use activeFocus rather than focus to determine that Text* has focus

To post a comment you must log in.
Zsombor Egri (zsombi) wrote :

Makes sense!

review: Approve
Zsombor Egri (zsombi) wrote :

Let's get the https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/04-apply-styleset/+merge/252467 as prereq, and please use theme instead of Theme.

review: Needs Fixing
1480. By Christian Dywan on 2015-04-16

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

Zsombor Egri (zsombi) wrote :

Much better, much better :)

review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/TextArea.qml'
2--- modules/Ubuntu/Components/TextArea.qml 2015-03-13 09:45:38 +0000
3+++ modules/Ubuntu/Components/TextArea.qml 2015-04-16 15:05:33 +0000
4@@ -104,7 +104,7 @@
5 text input. This property allows to control the highlight separately from
6 the focused behavior.
7 */
8- property bool highlighted: focus
9+ property bool highlighted: activeFocus
10 /*!
11 Text that appears when there is no focus and no content in the component
12 (hint text).
13
14=== modified file 'modules/Ubuntu/Components/TextField.qml'
15--- modules/Ubuntu/Components/TextField.qml 2015-04-09 09:42:36 +0000
16+++ modules/Ubuntu/Components/TextField.qml 2015-04-16 15:05:33 +0000
17@@ -110,7 +110,7 @@
18 text input. This property allows to control the highlight separately from
19 the focused behavior.
20 */
21- property bool highlighted: focus
22+ property bool highlighted: activeFocus
23
24 /*!
25 Text that appears when there is no content in the component.
26
27=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml'
28--- modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml 2015-04-09 09:42:36 +0000
29+++ modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml 2015-04-16 15:05:33 +0000
30@@ -25,13 +25,13 @@
31 // FIXME: needs type checking in themes to define the proper type to be used
32 // if color type is used, alpha value gets lost
33
34- property color color: (styledItem.focus || styledItem.highlighted) ? theme.palette.selected.fieldText : theme.palette.normal.fieldText
35+ property color color: (styledItem.activeFocus || styledItem.highlighted) ? theme.palette.selected.fieldText : theme.palette.normal.fieldText
36 property color selectedTextColor: theme.palette.selected.foregroundText
37 property color selectionColor: theme.palette.selected.foreground
38 /*!
39 Background fill color
40 */
41- property color backgroundColor: (styledItem.focus || styledItem.highlighted) ? theme.palette.selected.field : theme.palette.normal.field
42+ property color backgroundColor: (styledItem.activeFocus || styledItem.highlighted) ? theme.palette.selected.field : theme.palette.normal.field
43 property color errorColor: UbuntuColors.orange
44
45 /*!

Subscribers

People subscribed via source and target branches