Ubuntu UI Toolkit

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/popupUtilsOpenError into lp:ubuntu-ui-toolkit/staging

  1. popupUtilsOpenError
  2. Merge into staging
Proposed by Christian Dywan on 2015-02-05
Status: Merged
Approved by: Tim Peeters on 2015-02-05
Approved revision: 1397
Merged at revision: 1399
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/popupUtilsOpenError
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 11 lines (+1/-0)
1 file modified
modules/Ubuntu/Components/Popups/popupUtils.js (+1/-0)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/popupUtilsOpenError
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-02-05
Tim Peeters 2015-02-05 Approve on 2015-02-05
Review via email: mp+248738@code.launchpad.net

Commit Message

Print component creation errors in popupUtils.open

To post a comment you must log in.
Tim Peeters (tpeeters) wrote :

makes sense

review: Approve
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/Popups/popupUtils.js'
2--- modules/Ubuntu/Components/Popups/popupUtils.js 2013-05-27 09:48:42 +0000
3+++ modules/Ubuntu/Components/Popups/popupUtils.js 2015-02-05 12:13:38 +0000
4@@ -47,6 +47,7 @@
5 popupObject = popupComponent.createObject(rootObject);
6 }
7 if (!popupObject) {
8+ print(popupComponent.errorString().slice(0, -1));
9 print("PopupUtils.open(): Failed to create the popup object.");
10 return;
11 } else if (popupObject.hasOwnProperty("caller") && caller)

Subscribers

People subscribed via source and target branches