Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow

Revision history for this message
Zsombor Egri (zsombi) wrote :

> > Why do you derive from PageTreeNode?
> An oversight indeed. Thanks for noticing.
>
> > For now this is OK. But in general, as next step, the window should have its
> own units instance
> Between said discussion and now the goal seems to have changed from starting
> with a proof of concept to having a full implementation including tests - fine
> by me, I was starting to think about it as well, but just to point out that
> this is changing the plan :-D

We can have proof of concepts, of course. This component however seemed to me like a complete one, but yes, we can leave the tests for now, and add them once we move them into the main module.

« Back to merge proposal