Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/noFontsHere into lp:ubuntu-ui-toolkit

Proposed by Cris Dywan
Status: Superseded
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/noFontsHere
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 95 lines (+12/-5)
2 files modified
components.api (+6/-0)
tests/qmlapicheck.py (+6/-5)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/noFontsHere
Reviewer Review Type Date Requested Status
Zsombor Egri Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+220683@code.launchpad.net

This proposal has been superseded by a proposal from 2014-05-27.

Commit message

Tweak API parsing to include the Button.font property

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Looks great, and good to see other APIs coming in as well!

review: Approve

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components.api'
2--- components.api 2014-05-15 09:41:46 +0000
3+++ components.api 2014-05-26 16:04:42 +0000
4@@ -31,6 +31,7 @@
5 AbstractButton
6 property color color
7 property Gradient gradient
8+ property font font
9 property string iconPosition
10 CheckBox 0.1 1.0
11 AbstractButton
12@@ -140,6 +141,7 @@
13 property bool expanded
14 property bool multiSelection
15 property bool colourImage
16+ property Component delegate
17 property real containerHeight
18 property int selectedIndex
19 property bool currentlyExpanded
20@@ -204,12 +206,14 @@
21 Object 0.1 1.0
22 QtObject
23 default property internal children
24+ property list<QtObject> __defaultPropertyFix
25 OptionSelector 0.1 1.0
26 ListItem.Empty
27 property var model
28 property bool expanded
29 property bool multiSelection
30 property bool colourImage
31+ property Component delegate
32 property real containerHeight
33 property int selectedIndex
34 property bool currentlyExpanded
35@@ -235,6 +239,7 @@
36 Page 0.1 1.0
37 PageTreeNode
38 property string title
39+ property Item tools
40 property Item __customHeaderContents
41 property Flickable flickable
42 property list<Action> actions
43@@ -355,6 +360,7 @@
44 OrientationHelper
45 property Item dismissArea
46 property bool grabDismissAreaEvents
47+ property PropertyAnimation fadingAnimation
48 function show()
49 function hide()
50 function __closeIfHidden()
51
52=== modified file 'tests/qmlapicheck.py'
53--- tests/qmlapicheck.py 2014-04-24 09:18:38 +0000
54+++ tests/qmlapicheck.py 2014-05-26 16:04:42 +0000
55@@ -130,10 +130,10 @@
56 if '{' in line and '}' in line:
57 if filetype == 'qmltypes' and not in_builtin_type:
58 print(' ' + line.strip())
59- continue
60+ continue
61
62 # End of function/ signal/ Item block
63- if '}' in line:
64+ if '}' in line and not '{' in line:
65 in_block -= 1
66 block_meta = {}
67 if in_block == 1 and in_builtin_type:
68@@ -143,7 +143,7 @@
69 # Only root "Item {" is inspected for QML, otherwise all children
70 if in_block == 1 or filetype == 'qmltypes':
71 # Left hand side specifies a keyword, a type and a variable name
72- declaration = line.split(':')[0]
73+ declaration = line.split(':', 1)[0]
74 words = declaration.strip().split(' ')
75 # Skip types with prefixes considered builtin
76 if filetype == 'qmltypes' and words[0] == 'name':
77@@ -175,7 +175,8 @@
78 for word in words:
79 if word in keywords:
80 if filetype == 'qml':
81- signature = declaration.split('{')[0].strip()
82+ separator = '{' if 'function' in declaration else ':'
83+ signature = declaration.split(separator, 1)[0].strip()
84 if 'alias' in line:
85 no_mods = signature
86 for mod in ['readonly', 'default']:
87@@ -198,7 +199,7 @@
88 break
89
90 # Start of function/ signal/ Item block
91- if '{' in line:
92+ if '{' in line and not '}' in line:
93 in_block += 1
94 block_meta = {}
95 # The parent type can affect API

Subscribers

People subscribed via source and target branches

to status/vote changes: