Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/noDietForPopovers into lp:ubuntu-ui-toolkit/staging

Proposed by Christian Dywan on 2015-08-12
Status: Merged
Approved by: Zsombor Egri on 2015-08-13
Approved revision: 1605
Merged at revision: 1606
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/noDietForPopovers
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 12 lines (+1/-1)
1 file modified
src/Ubuntu/Components/Popups/1.3/Popover.qml (+1/-1)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/noDietForPopovers
Reviewer Review Type Date Requested Status
Zsombor Egri 2015-08-12 Approve on 2015-08-13
PS Jenkins bot continuous-integration Approve on 2015-08-12
Review via email: mp+267873@code.launchpad.net

Commit message

Revert unnecessary change of Popover minimumWidth

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Popups/1.3/Popover.qml'
2--- src/Ubuntu/Components/Popups/1.3/Popover.qml 2015-07-19 17:54:49 +0000
3+++ src/Ubuntu/Components/Popups/1.3/Popover.qml 2015-08-12 20:03:54 +0000
4@@ -210,7 +210,7 @@
5 objectName: "popover_foreground"
6
7 //styling properties
8- property real minimumWidth: units.gu(25)
9+ property real minimumWidth: units.gu(40)
10
11 property real maxWidth: dismissArea ? (internal.portrait ? dismissArea.width : dismissArea.width * 3/4) : 0.0
12 property real maxHeight: dismissArea ? (internal.portrait ? dismissArea.height * 3/4 : dismissArea.height) : 0.0

Subscribers

People subscribed via source and target branches