Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/literalStringReplace into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Zsombor Egri
Approved revision: 2116
Merged at revision: 2116
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/literalStringReplace
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 12 lines (+1/-1)
1 file modified
src/UbuntuToolkit/ucaction.cpp (+1/-1)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/literalStringReplace
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+306192@code.launchpad.net

Commit message

Use QStringLiteral with QString.replace

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Sorry to mess you up with this. Thanks for fixing.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/UbuntuToolkit/ucaction.cpp'
2--- src/UbuntuToolkit/ucaction.cpp 2016-09-20 06:39:55 +0000
3+++ src/UbuntuToolkit/ucaction.cpp 2016-09-20 08:28:24 +0000
4@@ -223,7 +223,7 @@
5 }
6 }
7 // Escape ampersands
8- displayText.replace("&&", "&");
9+ displayText.replace(QStringLiteral("&&"), QStringLiteral("&"));
10 return displayText;
11 }
12 void UCAction::setText(const QString &text)

Subscribers

People subscribed via source and target branches