Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/letGoAnchor into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Cris Dywan
Approved revision: 1419
Merged at revision: 1430
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/letGoAnchor
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 24 lines (+2/-1)
2 files modified
modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml (+1/-0)
tests/resources/navigation/Tabs.qml (+1/-1)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/letGoAnchor
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+250890@code.launchpad.net

Commit message

Set right anchor on tab overflow buttons

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Nice cut, thx!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml'
2--- modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml 2015-01-13 15:52:29 +0000
3+++ modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml 2015-02-25 08:50:56 +0000
4@@ -386,6 +386,7 @@
5 verticalCenterOffset: units.dp(-1)
6 left: parent.left
7 leftMargin: units.gu(2)
8+ right: parent.right
9 }
10 fontSize: "medium"
11 elide: Text.ElideRight
12
13=== modified file 'tests/resources/navigation/Tabs.qml'
14--- tests/resources/navigation/Tabs.qml 2015-02-10 13:40:55 +0000
15+++ tests/resources/navigation/Tabs.qml 2015-02-25 08:50:56 +0000
16@@ -32,7 +32,7 @@
17
18 Tab {
19 id: simpleTab
20- title: i18n.tr("Simple page #" + index)
21+ title: i18n.tr("Simple page #" + index + " to demonstrate tabs")
22 page: Page {
23 Label {
24 anchors.centerIn: parent

Subscribers

People subscribed via source and target branches