Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/jsDocs into lp:ubuntu-ui-toolkit/staging
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Tim Peeters on 2015-07-27 | ||||
| Approved revision: | 1559 | ||||
| Merged at revision: | 1580 | ||||
| Proposed branch: | lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/jsDocs | ||||
| Merge into: | lp:ubuntu-ui-toolkit/staging | ||||
| Diff against target: |
793 lines (+615/-8) 16 files modified
components.api (+3/-3) documentation/ubuntu-ui-toolkit-common.qdocconf (+2/-1) src/Ubuntu/Components/1.2/mathUtils.js (+23/-4) src/Ubuntu/Components/1.3/colorUtils.js (+37/-0) src/Ubuntu/Components/1.3/dateUtils.js (+145/-0) src/Ubuntu/Components/1.3/mathUtils.js (+61/-0) src/Ubuntu/Components/1.3/pageUtils.js (+10/-0) src/Ubuntu/Components/ComponentModule.pro (+2/-0) src/Ubuntu/Components/Popups/1.3/popupUtils.js (+101/-0) src/Ubuntu/Components/Popups/Popups.pro (+1/-0) src/Ubuntu/Components/Popups/qmldir (+1/-0) src/Ubuntu/Components/Themes/Ambiance/1.3/colorUtils.js (+36/-0) src/Ubuntu/Components/Themes/Ambiance/1.3/scrollbarUtils.js (+139/-0) src/Ubuntu/Components/Themes/Ambiance/1.3/sliderUtils.js (+48/-0) src/Ubuntu/Components/Themes/Ambiance/qmldir (+3/-0) src/Ubuntu/Components/qmldir (+3/-0) |
||||
| To merge this branch: | bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/jsDocs | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | 2015-07-07 | Approve on 2015-07-27 |
| Tim Peeters | 2015-07-07 | Approve on 2015-07-27 | |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-07-05.
Commit Message
Include Javascript libraries in QML documentation
Description of the Change
Note: I duplicated all Javascript files because docs don't include older API folders.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1548
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 1551. By Christian Dywan on 2015-07-17
-
Fix annotations and include popupUtils
- 1552. By Christian Dywan on 2015-07-17
-
Tweak the wording of popupUtils::open
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1552
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Tim Peeters (tpeeters) wrote : | # |
111 -// Linearly project a value x from [xmin, xmax] into [ymin, ymax]
112 +/*!
113 + \qmlmethod getFlickableChi
114 + Linearly project a value x from [xmin, xmax] into [ymin, ymax]
115 + */
116 function projectValue(x, xmin, xmax, ymin, ymax) {
117 return ((x - xmin) * ymax - (x - xmax) * ymin) / (xmax - xmin)
118 }
wrong function name.
| Tim Peeters (tpeeters) wrote : | # |
370 +/*!
371 + \qmlmethod mathUtils:
372 + Linearly project a value x from [xmin, xmax] into [ymin, ymax]
373 + */
374 +function projectValue(x, xmin, xmax, ymin, ymax) {
375 + return ((x - xmin) * ymax - (x - xmax) * ymin) / (xmax - xmin)
376 +}
| Tim Peeters (tpeeters) wrote : | # |
I think we need to evaluate which of these libraries we need to expose. I know that they are in the qmldir now, but colorUtils, dateUtils, scrollbarUtils, sliderUtils have functions that are just meant to be used inside the components.
- 1553. By Christian Dywan on 2015-07-23
-
Move Slider-/ Scrollbar-/ ColorUtils into Ambiance for 1.3
These are all internal components.
- 1554. By Christian Dywan on 2015-07-23
-
Fix types in qmldir of Ambiance theme
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1553
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1554
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1554
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Tim Peeters (tpeeters) wrote : | # |
sync with staging first to get the new directory structure.
- 1555. By Christian Dywan on 2015-07-24
- 1556. By Christian Dywan on 2015-07-24
-
Add js files to .pro files
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1556
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 1557. By Christian Dywan on 2015-07-24
| Tim Peeters (tpeeters) wrote : | # |
17 -Ubuntu.
18 +Ubuntu.
Why is 1.3 added here, while you define it for 1.2?
47 === modified file 'src/Ubuntu/
48 --- src/Ubuntu/
49 +++ src/Ubuntu/
50 @@ -14,9 +14,19 @@
51 * along with this program. If not, see <http://
52 */
53
54 +/*!
55 + \qmltype mathUtils
56 + \inqmlmodule Ubuntu.Components 1.2
57 + \ingroup ubuntu
58 + \brief Various mathematical utility functions.
59 + */
60 +
| Tim Peeters (tpeeters) wrote : | # |
122 +/*!
123 + \qmltype colorUtils
124 + \inqmlmodule Ubuntu.Components 1.3
125 + \ingroup ubuntu
126 + \brief Various chromatic utility functions.
127 + */
128
Didn't we agree to make colorUtils internal? If needed, with a second internal copy in Ambience?
| Tim Peeters (tpeeters) wrote : | # |
Ok, MathUtils was added in 1.3 as well.. any ideas why the components.api does not add 1.2?
> 17 -Ubuntu.
> 18 +Ubuntu.
>
> Why is 1.3 added here, while you define it for 1.2?
>
> 47 === modified file 'src/Ubuntu/
> 48 --- src/Ubuntu/
> +0000
> 49 +++ src/Ubuntu/
> +0000
> 50 @@ -14,9 +14,19 @@
> 51 * along with this program. If not, see
> <http://
> 52 */
> 53
> 54 +/*!
> 55 + \qmltype mathUtils
> 56 + \inqmlmodule Ubuntu.Components 1.2
> 57 + \ingroup ubuntu
> 58 + \brief Various mathematical utility functions.
> 59 + */
> 60 +
| Tim Peeters (tpeeters) wrote : | # |
I'm having a failure with 'make docs':
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1557
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 1558. By Christian Dywan on 2015-07-24
-
Change excluse dir in ubuntu-
ui-toolkit- common. qdocconf - 1559. By Christian Dywan on 2015-07-24
-
qdoc tweaks
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1558
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1559
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

FAILED: Continuous integration, rev:1548 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/1965/ jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-amd64- ci/693/ console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-armhf- ci/695/ console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-i386- ci/692/ console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/1965/ rebuild
http://