Merge into staging : inputHandlerKeyNavigation : Code : Ubuntu UI Toolkit

Reviewer	Review Type	Date Requested	Status
ubuntu-sdk-build-bot	continuous-integration		Approve on 2016-04-26
Zsombor Egri		2016-01-19	Approve on 2016-04-25
Review via email: mp+283049@code.launchpad.net

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-19:

#

FAILED: Continuous integration, rev:1806
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/70/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/169/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/70/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-19:

#

FAILED: Continuous integration, rev:1806
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/72/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/170/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/72/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-01-19

1807. By Cris Dywan on 2016-01-19: Deduplicate code paths in InputHandler

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-19:

#

FAILED: Continuous integration, rev:1807
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/74/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/173/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/74/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-19:

#

PASSED: Continuous integration, rev:1807
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/72/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/174/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/72/rebuild

review: Approve (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-01-20

1808. By Cris Dywan on 2016-01-20: Add focus colors to the palette

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-20:

#

FAILED: Continuous integration, rev:1808
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/102/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/235/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/102/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-20:

#

FAILED: Continuous integration, rev:1808
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/100/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/236/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/100/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-01-26

1809. By Cris Dywan on 2016-01-26: Merge lp:ubuntu-ui-toolkit/staging

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-26:

#

FAILED: Continuous integration, rev:1809
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/162/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/362/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/162/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-26:

#

FAILED: Continuous integration, rev:1809
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/159/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/364/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/159/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-01-28

1810. By Cris Dywan on 2016-01-28: Merge lp:ubuntu-ui-toolkit/staging

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-28:

#

FAILED: Continuous integration, rev:1810
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/184/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/447/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64/184/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-28:

#

FAILED: Continuous integration, rev:1810
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/195/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/448/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/195/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-01-28:

#

FAILED: Continuous integration, rev:1810
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/197/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/453/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-singlenode/197/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-03-10

1811. By Zoltan Balogh on 2016-03-10: Sync with staging and resolve conflict on src/Ubuntu/Components/plugin/ucstyleditembase.h

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1811
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/453/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1562/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/453/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1811
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/230/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1563/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/230/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1811
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/463/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1564/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/463/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1811
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/207/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1565/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/207/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/125/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-03-10

1812. By Cris Dywan on 2016-03-10: Drop extra focus/focusText declarations from PaletteValues.qml

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1812
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/454/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1569/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/454/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1812
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/231/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1570/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/231/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1812
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/208/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1571/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/208/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

PASSED: Continuous integration, rev:1812
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/464/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1572/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/464/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/126/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-03-10

1813. By Cris Dywan on 2016-03-10: Verify keyNavigationFocus after (Shift)Tab in tst_focus

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1813
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/456/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1579/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/456/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1813
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/233/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1580/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/233/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

FAILED: Continuous integration, rev:1813
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/210/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1581/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/210/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

PASSED: Continuous integration, rev:1813
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/466/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1582/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/466/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-10:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/128/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-25:

#

FAILED: Continuous integration, rev:1813
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/576/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2150/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/576/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-25:

#

FAILED: Continuous integration, rev:1813
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/356/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2153/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/356/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-25:

#

FAILED: Continuous integration, rev:1813
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/331/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2154/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/331/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-25:

#

PASSED: Continuous integration, rev:1813
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/588/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2157/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/588/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-03-25:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/211/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-04-07

1814. By Cris Dywan on 2016-04-07: Add MockKeyboard13 to sort out the versioning errors

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-07:

#

FAILED: Continuous integration, rev:1814
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/638/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2411/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/638/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-07:

#

FAILED: Continuous integration, rev:1814
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/419/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2412/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/419/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-07:

#

FAILED: Continuous integration, rev:1814
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/393/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2414/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/393/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-07:

#

FAILED: Continuous integration, rev:1814
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/259/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/638/console
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/419/console
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/393/console
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2415/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2411
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2412
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2414

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/259/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-04-18

1815. By Cris Dywan on 2016-04-08: Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging
1816. By Cris Dywan on 2016-04-18: Overload focus mechanics to avoid bubbling up of focus from children

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-18:

#

FAILED: Continuous integration, rev:1816
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/676/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2740/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/676/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-18:

#

FAILED: Continuous integration, rev:1816
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/709/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2741/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/709/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-18:

#

FAILED: Continuous integration, rev:1816
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/490/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2742/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/490/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-18:

#

FAILED: Continuous integration, rev:1816
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/464/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2743/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/464/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-18:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/307/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Zsombor Egri (zsombi) wrote on 2016-04-24:

#

I am not confident that making the property writable is a good way to solve this issue. We must find an other way to solve this issue: what about overriding the key filtering with some attached property, like the Keys QML attached property group does. That one hooks into the key handling and not as a generic event filter, perhaps we could influence the focus key handling through the same logic.

review: Needs Fixing

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-04-25

1817. By Cris Dywan on 2016-04-25: Keep keyNavigationFocus read-only but inclusive of children

Revision history for this message

Zsombor Egri (zsombi) wrote on 2016-04-25:

#

Ok, this looks much better! Thanks for spending time to find the way!

review: Approve

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

FAILED: Continuous integration, rev:1817
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/747/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2923/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/747/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

FAILED: Continuous integration, rev:1817
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/528/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2924/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/528/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

FAILED: Continuous integration, rev:1817
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/714/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2925/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/714/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

FAILED: Continuous integration, rev:1817
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/502/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2926/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/502/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/337/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation updated on 2016-04-25

1818. By Cris Dywan on 2016-04-25: Restore activeFocusOnPress alias and docs

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

PASSED: Continuous integration, rev:1818
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/748/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2928/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/748/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

PASSED: Continuous integration, rev:1818
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/529/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2929/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/529/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

PASSED: Continuous integration, rev:1818
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/503/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2930/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/503/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

PASSED: Continuous integration, rev:1818
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/715/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2931/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/715/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-25:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/338/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-26:

#

PASSED: Continuous integration, rev:1818
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/505/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2938/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/505/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-26:

#

PASSED: Continuous integration, rev:1818
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/531/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2939/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/531/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-26:

#

PASSED: Continuous integration, rev:1818
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/750/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2940/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/750/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-04-26:

#

PASSED: Continuous integration, rev:1818
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/717/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/2941/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/717/rebuild

review: Approve (continuous-integration)

Ubuntu UI Toolkit

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation into lp:ubuntu-ui-toolkit/staging

Commit message

Description of the change

Preview Diff

Subscribers

 === modified file 'src/Ubuntu/Components/1.3/InputHandler.qml'
 --- src/Ubuntu/Components/1.3/InputHandler.qml	2016-01-04 09:51:42 +0000
 +++ src/Ubuntu/Components/1.3/InputHandler.qml	2016-04-25 18:49:14 +0000
@@ -16,6 +16,7 @@
  import QtQuick 2.4
  import Ubuntu.Components 1.3
++import Ubuntu.Components.Popups 1.3
  /*
    This component is a unified text selection and scrolling handler for both
@@ -290,6 +291,16 @@
      Connections {
          target: main
          ignoreUnknownSignals: true
++        onActiveFocusChanged: {
++            if (!main.activeFocus) {
++                input.focus = false;
++            }
++        }
++        onKeyNavigationFocusChanged: {
++            if (main.keyNavigationFocus) {
++                input.forceActiveFocus();
++            }
++        }
          onFocusChanged: {
              UbuntuApplication.inputMethod.commit()
              state = (main.focus) ? "" : "inactive";
@@ -297,6 +308,10 @@
                  input.forceActiveFocus()
+             }
+         }
++        onVisibleChanged: {
++            if (!main.visible)
++                main.focus = false;
++        }
+     }
      // input specific signals
@@ -311,7 +326,11 @@
+             }
+         }
          // make sure we show the OSK
--        onActiveFocusChanged: showInputPanel()
++        onActiveFocusChanged: {
++            if (!input.activeFocus && popover)
++                PopupUtils.close(popover);
++            showInputPanel();
++        }
+     }
      // inner or outer Flickable controlling
 === modified file 'src/Ubuntu/Components/1.3/TextArea.qml'
 --- src/Ubuntu/Components/1.3/TextArea.qml	2016-04-20 15:00:27 +0000
 +++ src/Ubuntu/Components/1.3/TextArea.qml	2016-04-25 18:49:14 +0000
@@ -103,7 +103,7 @@
        text input. This property allows to control the highlight separately from
        the focused behavior.
        */
--    property bool highlighted: activeFocus
++    property bool highlighted
      /*!
        Text that appears when there is no focus and no content in the component
        (hint text).
@@ -538,13 +538,6 @@
        */
      property alias wrapMode:editor.wrapMode
--    /*!
--      Whether the TextArea should gain active focus on a mouse press. By default
--      this is set to true.
--      \qmlproperty bool activeFocusOnPress
--    */
--    property alias activeFocusOnPress: editor.activeFocusOnPress
--
      // signals
      /*!
        This handler is called when the user clicks on a link embedded in the text.
@@ -756,15 +749,7 @@
+     }
      //internals
--
      activeFocusOnPress: true
--    activeFocusOnTab: true
--
--    /*!\internal */
--    onVisibleChanged: {
--        if (!visible)
--            control.focus = false;
--    }
      // Escape should close the context menu even if the menu takes no input focus
      Keys.onEscapePressed: {
@@ -832,7 +817,7 @@
+         }
          // hint is shown till user types something in the field
          visible: (editor.text == "") && !editor.inputMethodComposing
--        color: theme.palette.normal.base
++        color: theme.palette.normal.baseText
          font: editor.font
          elide: Text.ElideRight
          wrapMode: Text.WordWrap
@@ -868,14 +853,11 @@
              objectName: "text_input"
              readOnly: false
              id: editor
--            focus: true
              width: control.contentWidth
              height: Math.max(control.contentHeight, editor.contentHeight)
              wrapMode: TextEdit.WrapAtWordBoundaryOrAnywhere
              mouseSelectionMode: TextEdit.SelectWords
              selectByMouse: true
--            activeFocusOnPress: true
--            onActiveFocusChanged: if (!activeFocus && inputHandler.popover) PopupUtils.close(inputHandler.popover)
              cursorDelegate: TextCursor {
                  handler: inputHandler
+             }
 === modified file 'src/Ubuntu/Components/1.3/TextField.qml'
 --- src/Ubuntu/Components/1.3/TextField.qml	2016-04-20 15:00:27 +0000
 +++ src/Ubuntu/Components/1.3/TextField.qml	2016-04-25 18:49:14 +0000
@@ -110,7 +110,7 @@
        text input. This property allows to control the highlight separately from
        the focused behavior.
        */
--    property bool highlighted: activeFocus
++    property bool highlighted
      /*!
        Text that appears when there is no content in the component.
@@ -833,14 +833,8 @@
      // internals
++    // Overload focus mechanics to avoid bubbling up of focus from children
      activeFocusOnPress: true
--    activeFocusOnTab: true
--
--    /*! \internal */
--    onVisibleChanged: {
--        if (!visible)
--            control.focus = false;
--    }
      // Escape should close the context menu even if the menu takes no input focus
      Keys.onEscapePressed: {
@@ -1019,7 +1013,6 @@
              id: editor
              objectName: "text_input"
              // FocusScope will forward focus to this component
--            focus: true
              anchors.verticalCenter: parent.verticalCenter
              verticalAlignment: TextInput.AlignVCenter
              width: flicker.width
@@ -1038,8 +1031,6 @@
              // overrides
              selectByMouse: true
--            activeFocusOnPress: true
--            onActiveFocusChanged: if (!activeFocus && inputHandler.popover) PopupUtils.close(inputHandler.popover)
              // input selection and navigation handling
              Ubuntu.Mouse.forwardTo: [inputHandler]
 === modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml'
 --- src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml	2016-01-27 15:17:56 +0000
 +++ src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml	2016-04-25 18:49:14 +0000
@@ -35,6 +35,7 @@
      /*!
        Background fill color
        */
++    property color borderColor: theme.palette.normal.base
      property color backgroundColor: styledItem.enabled
                                          ? ((styledItem.activeFocus || styledItem.highlighted)
                                              ? theme.palette.selected.field
@@ -58,12 +59,23 @@
      /*!
        Text input background
        */
++    FocusShape {
++    }
++
      property Component background: UbuntuShape {
          property bool error: (styledItem.hasOwnProperty("errorHighlight") && styledItem.errorHighlight && !styledItem.acceptableInput)
          onErrorChanged: (error) ? visuals.errorColor : visuals.backgroundColor;
--        backgroundColor: visuals.backgroundColor
--        anchors.fill: parent
++        backgroundColor: visuals.borderColor
++        aspect: UbuntuShape.Flat
          visible: !styledItem.readOnly
++        anchors.fill: parent
++
++        UbuntuShape {
++            anchors.fill: parent
++            anchors.margins: parent.visible ? units.gu(0.2) : 0
++            backgroundColor: visuals.backgroundColor
++            aspect: UbuntuShape.Flat
++        }
+     }
      Loader {
 === modified file 'src/Ubuntu/Components/plugin/ucstyleditembase.cpp'
 --- src/Ubuntu/Components/plugin/ucstyleditembase.cpp	2016-02-29 16:50:41 +0000
 +++ src/Ubuntu/Components/plugin/ucstyleditembase.cpp	2016-04-25 18:49:14 +0000
@@ -42,6 +42,15 @@
      Q_D(const UCStyledItemBase);
      return d->keyNavigationFocus;
+ }
++void UCStyledItemBase::setKeyNavigationFocus(bool v)
++{
++    Q_D(UCStyledItemBase);
++    if (d->keyNavigationFocus == v)
++        return;
++
++    d->keyNavigationFocus = v;
++    Q_EMIT keyNavigationFocusChanged();
++}
  bool UCStyledItemBase::activeFocusOnTab2() const
+ {
@@ -532,6 +541,10 @@
      if (change == ItemParentHasChanged) {
          // update parentItem
          d_func()->oldParentItem = data.item;
++    } else if (change == ItemActiveFocusHasChanged) {
++        // Children may retain focus as if it was the StyledItem itself
++        if (!hasActiveFocus())
++            setKeyNavigationFocus(false);
+     }
+ }
@@ -539,15 +552,10 @@
+ {
      QQuickItem::focusInEvent(event);
--    Q_D(UCStyledItemBase);
--    if (d->keyNavigationFocus)
--        return;
--
      switch (event->reason()) {
          case Qt::TabFocusReason:
          case Qt::BacktabFocusReason:
--            d->keyNavigationFocus = true;
--            Q_EMIT keyNavigationFocusChanged();
++            setKeyNavigationFocus(true);
              break;
          default:
              // Mouse or window focus don't affect keyNavigationFocus status
@@ -555,18 +563,6 @@
+     }
+ }
--void UCStyledItemBase::focusOutEvent(QFocusEvent *event)
--{
--    QQuickItem::focusOutEvent(event);
--
--    Q_D(UCStyledItemBase);
--    if (!d->keyNavigationFocus)
--        return;
--
--    d->keyNavigationFocus = false;
--    Q_EMIT keyNavigationFocusChanged();
--}
--
  // grab pressed state and focus if it can be
  void UCStyledItemBase::mousePressEvent(QMouseEvent *event)
+ {
 === modified file 'src/Ubuntu/Components/plugin/ucstyleditembase.h'
 --- src/Ubuntu/Components/plugin/ucstyleditembase.h	2016-01-16 15:52:56 +0000
 +++ src/Ubuntu/Components/plugin/ucstyleditembase.h	2016-04-25 18:49:14 +0000
@@ -77,7 +77,7 @@
      void componentComplete();
      void itemChange(ItemChange change, const ItemChangeData &data);
      void focusInEvent(QFocusEvent *key);
--    void focusOutEvent(QFocusEvent *key);
++    void setKeyNavigationFocus(bool value);
      void mousePressEvent(QMouseEvent *event);
      bool childMouseEventFilter(QQuickItem *child, QEvent *event);
 === added file 'tests/unit_x11/tst_components/MockKeyboard.qml'
 --- tests/unit_x11/tst_components/MockKeyboard.qml	1970-01-01 00:00:00 +0000
 +++ tests/unit_x11/tst_components/MockKeyboard.qml	2016-04-25 18:49:14 +0000
@@ -0,0 +1,64 @@
++/*
++ * Copyright 2015 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++import QtQuick 2.4
++import Ubuntu.Components 1.2
++
++Object {
++    id: inputMethod
++    function show() { visible = true; }
++    function commit() { }
++    property bool visible: false
++    property rect keyboardRectangle: Qt.rect(0, 0, 0, units.gu(20))
++
++    Rectangle {
++        x: parent.x
++        y: parent.height - height
++        width: parent.width
++        height: inputMethod.keyboardRectangle.height
++        visible: inputMethod.visible
++
++        parent: QuickUtils.rootItem(inputMethod)
++        color: UbuntuColors.silk
++        opacity: 0.5
++        // Always on top, even modal Dialog overlay
++        z: 100
++
++        Flow {
++            anchors.fill: parent
++            anchors.margins: units.dp(2)
++
++            Repeater {
++                model: [ 1, 2, 3, 4, 5, 6, 7, 8, 9, 0,
++                         'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p',
++                         'a', 's', 'd', 'f', 'g', 'h', 'j', 'k', 'l', ';',
++                         'z', 'x', 'c', 'v', ' ', 'b', 'n', 'm', ',', '.'  ]
++
++                Button {
++                    text: modelData
++                    color: UbuntuColors.blue
++                    height: (parent.height - units.dp(2)) / 4
++                    width: (parent.width - units.dp(2)) / 10
++                }
++            }
++        }
++
++        MouseArea {
++            anchors.fill: parent
++            onClicked: parent.forceActiveFocus(Qt.MouseFocusReason)
++        }
++    }
++}
 === renamed file 'tests/unit_x11/tst_components/MockKeyboard.qml' => 'tests/unit_x11/tst_components/MockKeyboard13.qml'
 --- tests/unit_x11/tst_components/MockKeyboard.qml	2016-01-13 16:07:58 +0000
 +++ tests/unit_x11/tst_components/MockKeyboard13.qml	2016-04-25 18:49:14 +0000
@@ -15,7 +15,7 @@
   */
  import QtQuick 2.4
--import Ubuntu.Components 1.2
++import Ubuntu.Components 1.3
  Object {
      id: inputMethod
 === modified file 'tests/unit_x11/tst_components/tst_focus.qml'
 --- tests/unit_x11/tst_components/tst_focus.qml	2016-04-13 16:12:41 +0000
 +++ tests/unit_x11/tst_components/tst_focus.qml	2016-04-25 18:49:14 +0000
@@ -60,6 +60,7 @@
                  id: textFieldSecondaryItem
                  height: parent.height
                  width: height
++                Component.onCompleted: activeFocusOnTab = false
+             }
+         }
          TextArea {
@@ -266,6 +267,7 @@
              } else {
                  verify(data.to.activeFocusOnTab, "Target doesn't take keyboard focus");
                  keyClick(data.key);
++                verify(data.to.keyNavigationFocus, "Target doesn't have keyNavigationFocus");
+             }
              waitForRendering(data.to, 500);
              verify(!data.from.activeFocus, "Source component still keeps focus");
 === modified file 'tests/unit_x11/tst_components/tst_textinput_common13.qml'
 --- tests/unit_x11/tst_components/tst_textinput_common13.qml	2016-03-15 13:26:55 +0000
 +++ tests/unit_x11/tst_components/tst_textinput_common13.qml	2016-04-25 18:49:14 +0000
@@ -131,7 +131,7 @@
+         }
+     }
--    MockKeyboard {
++    MockKeyboard13 {
          Component.onCompleted: UbuntuApplication.inputMethod = this
+     }