Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/incubateNull into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Tim Peeters
Approved revision: 1682
Merged at revision: 1683
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/incubateNull
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 16 lines (+4/-2)
1 file modified
src/Ubuntu/Components/1.3/PageWrapperUtils.js (+4/-2)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/incubateNull
Reviewer Review Type Date Requested Status
Tim Peeters Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+274152@code.launchpad.net

Commit message

Handle incubateObject returning null in PageWrapperUtils

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

cool, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/1.3/PageWrapperUtils.js'
2--- src/Ubuntu/Components/1.3/PageWrapperUtils.js 2015-09-29 05:24:47 +0000
3+++ src/Ubuntu/Components/1.3/PageWrapperUtils.js 2015-10-12 14:38:34 +0000
4@@ -73,8 +73,10 @@
5 incubator = pageComponent.incubateObject(pageWrapper);
6 }
7
8- pageWrapper.incubator.status = incubator.status;
9- if (incubator.status != Component.Ready) {
10+ if (!incubator) {
11+ throw new Error("Error while loading page: " + pageComponent.errorString());
12+ } else if (incubator.status != Component.Ready) {
13+ pageWrapper.incubator.status = incubator.status;
14 incubator.onStatusChanged = incubatorStatusChanged;
15 } else {
16 incubatorStatusChanged(incubator.status);

Subscribers

People subscribed via source and target branches