Ubuntu UI Toolkit

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/hiddenWindowPopup into lp:ubuntu-ui-toolkit/staging

  1. hiddenWindowPopup
  2. Merge into staging
Proposed by Christian Dywan on 2017-02-16
Status: Needs review
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/hiddenWindowPopup
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 26 lines (+16/-0)
1 file modified
tests/unit/visual/tst_popups_dialog.13.qml (+16/-0)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/hiddenWindowPopup
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Needs Fixing on 2017-02-16
Ubuntu SDK team 2017-02-16 Pending
Review via email: mp+317530@code.launchpad.net

Commit Message

Add unit test case opening popup before showing window

Description of the Change

The fix for bug 166420 didn't introduce a regression test.

To post a comment you must log in.
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Reply
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Reply
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Reply
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Reply
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Continuous integration, rev:2172
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/904/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1667/console
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1452/console
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1417/console
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/231/console
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7711/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7710
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7707
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7708
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7709

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/904/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

2172. By Christian Dywan on 2017-02-16

Add unit test case opening popup before showing window

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/unit/visual/tst_popups_dialog.13.qml'
2--- tests/unit/visual/tst_popups_dialog.13.qml 2017-01-05 14:11:37 +0000
3+++ tests/unit/visual/tst_popups_dialog.13.qml 2017-02-16 17:29:08 +0000
4@@ -34,6 +34,22 @@
5 }
6
7 UbuntuTestCase {
8+ id: hiddenTest
9+ name: "Popups.Dialog.Hidden"
10+
11+ property bool dialogDestroyed: false
12+
13+ function test_dismiss_dialog_no_focus_window_bug1664620() {
14+ verify(!hiddenTest.windowShown);
15+ var dlg = PopupUtils.open(dialog);
16+ waitForRendering(dlg);
17+ dlg.Component.destruction.connect(function() { hiddenTest.dialogDestroyed = true });
18+ keyClick(Qt.Key_Escape);
19+ tryCompare(hiddenTest, "dialogDestroyed", true, 500, "Dialog not destroyed");
20+ }
21+ }
22+
23+ UbuntuTestCase {
24 id: test
25 name: "Popups.Dialog"
26 when: windowShown

Subscribers

People subscribed via source and target branches