Ubuntu UI Toolkit

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dropQuestionableColorTestsFromTstTextarea11Qml into lp:ubuntu-ui-toolkit/staging

  1. dropQuestionableColorTestsFromTstTextarea11Qml
  2. Merge into staging
Proposed by Christian Dywan on 2016-10-11
Status: Merged
Approved by: Tim Peeters on 2016-10-14
Approved revision: 2137
Merged at revision: 2142
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dropQuestionableColorTestsFromTstTextarea11Qml
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 30 lines (+0/-13)
1 file modified
tests/unit/visual/tst_textarea.11.qml (+0/-13)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dropQuestionableColorTestsFromTstTextarea11Qml
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve on 2016-10-14
Tim Peeters 2016-10-11 Approve on 2016-10-14
Review via email: mp+308106@code.launchpad.net

Commit Message

Drop questionable color tests from tst_textarea.11.qml

Description of the Change

The color-related tests that seemingly¹ now started failing don't make sense - the default colors can't possibly match because the upstream component has no Ubuntu theming.

¹Colors used to always compare equal, that bug was fixed in Qt 5.6.

To post a comment you must log in.
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Continuous integration, rev:2137
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/824/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1535/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1542
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1326
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1292
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/106
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7058/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7048
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7057
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7055
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7054
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7056

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/824/rebuild

review: Needs Fixing (continuous-integration)
Tim Peeters (tpeeters) wrote :

Seems good, but jenkins failed (on missing device?). Let's see if it'll pass autolanding.

review: Approve
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'tests/unit/visual/FIXME-QT56_textarea.11.qml' => 'tests/unit/visual/tst_textarea.11.qml'
2--- tests/unit/visual/FIXME-QT56_textarea.11.qml 2016-09-16 11:20:57 +0000
3+++ tests/unit/visual/tst_textarea.11.qml 2016-10-11 11:01:31 +0000
4@@ -137,11 +137,6 @@
5 compare(textArea.canUndo,textEdit.canUndo,"TextArea.canUndo is same as TextEdit.canUndo")
6 }
7
8- // FIXME: Fails with Qt 5.6. See bug #1624342.
9- function test_0_color() {
10- compare(textArea.color,textEdit.color,"TextArea.color is same as TextEdit.canUndo")
11- }
12-
13 function test_0_cursorDelegate() {
14 verify(textArea.cursorDelegate === null, "TextArea.cursorDelegate is not null")
15 }
16@@ -220,14 +215,6 @@
17 compare(textArea.selectedText,textEdit.selectedText,"TextArea.selectedText is same as TextEdit.selectedText")
18 }
19
20- function test_0_selectedTextColor() {
21- compare(textArea.selectedTextColor,textEdit.selectedTextColor,"TextArea.selectedTextColor is same as TextEdit.selectedTextColor")
22- }
23-
24- function test_0_selectionColor() {
25- compare(textArea.selectionColor,textEdit.selectionColor,"TextArea.selectionColor is same as TextEdit.selectionColor")
26- }
27-
28 function test_0_selectionEnd() {
29 compare(textArea.selectionEnd,textEdit.selectionEnd,"TextArea.selectionEnd is same as TextEdit.selectionEnd")
30 }

Subscribers

People subscribed via source and target branches