Ubuntu UI Toolkit

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dontSkipTheEntiretyOfTstTextfield11Qml into lp:ubuntu-ui-toolkit/staging

  1. dontSkipTheEntiretyOfTstTextfield11Qml
  2. Merge into staging
Proposed by Christian Dywan on 2016-10-11
Status: Merged
Approved by: Tim Peeters on 2016-10-11
Approved revision: 2137
Merged at revision: 2140
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dontSkipTheEntiretyOfTstTextfield11Qml
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 12 lines (+1/-1)
1 file modified
tests/unit/visual/tst_textfield.11.qml (+1/-1)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dontSkipTheEntiretyOfTstTextfield11Qml
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve on 2016-10-11
Tim Peeters 2016-10-11 Approve on 2016-10-11
Review via email: mp+308099@code.launchpad.net

Commit Message

Don't skip the entirety of tst_textfield.11.qml

To post a comment you must log in.
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

PASSED: Continuous integration, rev:2137
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/823/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1533
        deb: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1533/artifact/artifacts/*zip*/artifacts.zip
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1540
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1324
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1290
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/104
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7047/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7046
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7044
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7043
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7042
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7045

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/823/rebuild

review: Approve (continuous-integration)
Tim Peeters (tpeeters) wrote :

This makes sense. Thanks.

review: Approve
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'tests/unit/visual/FIXME-QT56_textfield.11.qml' => 'tests/unit/visual/tst_textfield.11.qml'
2--- tests/unit/visual/FIXME-QT56_textfield.11.qml 2016-09-16 11:20:57 +0000
3+++ tests/unit/visual/tst_textfield.11.qml 2016-10-11 09:28:28 +0000
4@@ -164,8 +164,8 @@
5 compare(textField.cursorPosition, 0, "cursorPosition 0 by default")
6 }
7
8- // FIXME: Fails with Qt 5.6. See bug #1624340.
9 function test_0_cursorRectangle() {
10+ skip('FIXME: Fails with Qt 5.6. See bug #1624340');
11 compare(textField.cursorRectangle, Qt.rect(0, 0, 0, 0), "cursorRectangle 0 by default")
12 }
13

Subscribers

People subscribed via source and target branches