Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dietTextFieldsTrunk into lp:ubuntu-ui-toolkit

Proposed by Cris Dywan
Status: Rejected
Rejected by: Cris Dywan
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dietTextFieldsTrunk
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 13 lines (+2/-1)
1 file modified
src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml (+2/-1)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dietTextFieldsTrunk
Reviewer Review Type Date Requested Status
Zsombor Egri Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+294354@code.launchpad.net

Commit message

Slimmer frame for TextFields: 0.5dp

To post a comment you must log in.
1315. By Cris Dywan

Slimmer frame for TextFields: 0.5dp

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Visuals are OK, if design likes it, we can let it go.
There's a weird CI failure though...

review: Approve

Unmerged revisions

1315. By Cris Dywan

Slimmer frame for TextFields: 0.5dp

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml'
2--- src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml 2016-01-28 11:54:29 +0000
3+++ src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml 2016-05-11 11:22:06 +0000
4@@ -72,7 +72,8 @@
5
6 UbuntuShape {
7 anchors.fill: parent
8- anchors.margins: parent.visible ? units.gu(0.2) : 0
9+ anchors.margins: parent.visible ? units.dp(0.5) : 0
10+ radius: units.gu(1.7)
11 backgroundColor: visuals.backgroundColor
12 aspect: UbuntuShape.Flat
13 }

Subscribers

People subscribed via source and target branches

to status/vote changes: