Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/boldLinkingforQt5.4 into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Cris Dywan
Approved revision: 1353
Merged at revision: 1357
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/boldLinkingforQt5.4
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 40 lines (+4/-4)
3 files modified
modules/Ubuntu/Components/AbstractButton.qml (+1/-1)
modules/Ubuntu/Components/Page.qdoc (+1/-1)
modules/Ubuntu/Components/plugin/ucaction.cpp (+2/-2)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/boldLinkingforQt5.4
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Timo Jyrinki Approve
Review via email: mp+243154@code.launchpad.net

Commit message

Change offending links into bold font

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I cannot now test this fix at the moment, since as of 5.4.0 RC there is a new build problem with UITK bug #1397979

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/AbstractButton.qml'
2--- modules/Ubuntu/Components/AbstractButton.qml 2014-11-28 08:19:13 +0000
3+++ modules/Ubuntu/Components/AbstractButton.qml 2014-11-28 13:31:36 +0000
4@@ -40,7 +40,7 @@
5
6 /*!
7 This handler is called when there is a mouse click on the button
8- and the button is not disabled. If \l action is defined,
9+ and the button is not disabled. If \b action is defined,
10 the action will be triggered.
11 */
12 signal clicked()
13
14=== modified file 'modules/Ubuntu/Components/Page.qdoc'
15--- modules/Ubuntu/Components/Page.qdoc 2014-06-27 13:27:56 +0000
16+++ modules/Ubuntu/Components/Page.qdoc 2014-11-28 13:31:36 +0000
17@@ -71,7 +71,7 @@
18 \qmlproperty Item Page::tools
19 \deprecated
20 The toolbar items associated with this Page.
21- DEPRECATED. Use \l head.actions instead.
22+ DEPRECATED. Use \b head.actions instead.
23 */
24
25 /*!
26
27=== modified file 'modules/Ubuntu/Components/plugin/ucaction.cpp'
28--- modules/Ubuntu/Components/plugin/ucaction.cpp 2014-09-16 05:49:26 +0000
29+++ modules/Ubuntu/Components/plugin/ucaction.cpp 2014-11-28 13:31:36 +0000
30@@ -28,8 +28,8 @@
31 *
32 * Actions can be used to define a specific task to be executed in different
33 * contexts using different components. The same action can be assigned to
34- * a \l Button, a \l Checkbox or even a \l TextField. The \l triggered signal
35- * is emitted depending on the component. \l Button and \l CheckBox for instance
36+ * a \l Button, a \b Checkbox or even a \l TextField. The \l triggered signal
37+ * is emitted depending on the component. \l Button and \b CheckBox for instance
38 * emits the signal when clicked, whereas \l TextField emits the signal when
39 * its accepted signal is triggered.
40 *

Subscribers

People subscribed via source and target branches