Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/blueCursor into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Superseded
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/blueCursor
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 558 lines (+256/-72)
15 files modified
components.api (+6/-0)
examples/ubuntu-ui-toolkit-gallery/Colors.qml (+72/-0)
examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml (+5/-1)
modules/Ubuntu/Components/Colors/FIXME (+4/-0)
modules/Ubuntu/Components/Colors/UbuntuColors.qml (+131/-0)
modules/Ubuntu/Components/Colors/UbuntuColors10.qml (+4/-48)
modules/Ubuntu/Components/TextArea.qml (+2/-1)
modules/Ubuntu/Components/TextField.qml (+2/-1)
modules/Ubuntu/Components/Themes/Ambiance/Palette.qml (+9/-8)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+1/-1)
modules/Ubuntu/Components/Themes/Ambiance/TextSelectionEndCursorStyle.qml (+1/-1)
modules/Ubuntu/Components/Themes/Ambiance/TextSelectionStartCursorStyle.qml (+3/-2)
modules/Ubuntu/Components/Themes/SuruDark/Palette.qml (+3/-2)
modules/Ubuntu/Components/plugin/plugin.cpp (+10/-2)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+3/-5)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/blueCursor
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Needs Fixing
Review via email: mp+225304@code.launchpad.net

This proposal has been superseded by a proposal from 2014-07-11.

Commit message

Update selection and cursor to blue

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

FAIL! : components::TextInputTouchTests::test_long_tap_on_selected_text(TextField) 'wait for signal pressAndHold' returned FALSE. ()
   Loc: [/tmp/buildd/ubuntu-ui-toolkit-0.1.47+14.10.20140618bzr1131pkg0utopic1409+autopilot0/tests/unit_x11/tst_components/tst_textinput_touch.qml(197)]

1131. By Cris Dywan

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

FAIL! : components::TextInputTouchTests::test_long_tap_on_selected_text(TextField) 'wait for signal pressAndHold' returned FALSE. ()
   Loc: [/tmp/buildd/ubuntu-ui-toolkit-0.1.49+14.10.20140709bzr1131pkg0utopic1699+autopilot0/tests/unit_x11/tst_components/tst_textinput_touch.qml(197)]

Revision history for this message
Zsombor Egri (zsombi) wrote :

> FAIL! :
> components::TextInputTouchTests::test_long_tap_on_selected_text(TextField)
> 'wait for signal pressAndHold' returned FALSE. ()
> Loc: [/tmp/buildd/ubuntu-ui-toolkit-0.1.49+14.10.20140709bzr1131pkg0utopic1
> 699+autopilot0/tests/unit_x11/tst_components/tst_textinput_touch.qml(197)]

There was a bug in the test, see it fixed in https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/textinput-caret-and-selection/+merge/223236. Actually this whole MR was already under review, I asked you to review it :)

Revision history for this message
Cris Dywan (kalikiana) wrote :
1132. By Cris Dywan

Update tst_textinput_touch

Revision history for this message
Zsombor Egri (zsombi) wrote :

You are missing the TextField changes!

Some small comments inline

review: Needs Fixing
1133. By Cris Dywan

Also update the selection color in the TextField

1134. By Cris Dywan

Merge lp:~tpeeters/ubuntu-ui-toolkit/NewColors

1135. By Cris Dywan

Use UbuntuColors lightGrey, blue, darkGray in Palette

1136. By Cris Dywan

Set selected.foreground alpha in the Palette

1137. By Cris Dywan

Introduce "selection" palette value for selected text

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1132
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/584/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1860
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1557
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/416
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/416
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/416/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/416
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2119
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2956
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2956/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9694
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1304
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1747
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1747/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/584/rebuild

review: Approve (continuous-integration)
1138. By Cris Dywan

Update components.api

1139. By Cris Dywan

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

1140. By Cris Dywan

Slightly thicker caret

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components.api'
2--- components.api 2014-07-10 11:50:13 +0000
3+++ components.api 2014-07-11 13:24:19 +0000
4@@ -46,6 +46,12 @@
5 readonly property color coolGrey
6 property Gradient orangeGradient
7 property Gradient greyGradient
8+ readonly property color lightGrey
9+ readonly property color darkGrey
10+ readonly property color red
11+ readonly property color green
12+ readonly property color blue
13+ readonly property color purple
14 ComboButton 1.1
15 Button
16 property bool expanded
17
18=== added file 'examples/ubuntu-ui-toolkit-gallery/Colors.qml'
19--- examples/ubuntu-ui-toolkit-gallery/Colors.qml 1970-01-01 00:00:00 +0000
20+++ examples/ubuntu-ui-toolkit-gallery/Colors.qml 2014-07-11 13:24:19 +0000
21@@ -0,0 +1,72 @@
22+/*
23+ * Copyright 2014 Canonical Ltd.
24+ *
25+ * This program is free software; you can redistribute it and/or modify
26+ * it under the terms of the GNU Lesser General Public License as published by
27+ * the Free Software Foundation; version 3.
28+ *
29+ * This program is distributed in the hope that it will be useful,
30+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
31+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
32+ * GNU Lesser General Public License for more details.
33+ *
34+ * You should have received a copy of the GNU Lesser General Public License
35+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
36+ */
37+
38+import QtQuick 2.2
39+import Ubuntu.Components 1.1
40+
41+Template {
42+ objectName: "colorsTemplate"
43+
44+ TemplateSection {
45+ title: "UbuntuColors"
46+ className: "UbuntuColors"
47+
48+ // Except orange, none of the colors from UbuntuComponents 1.0
49+ // are included because they may be deprecated soon.
50+ TemplateRow {
51+ title: i18n.tr("Orange")
52+ UbuntuShape {
53+ color: UbuntuColors.orange
54+ }
55+ }
56+ TemplateRow {
57+ title: i18n.tr("Light grey")
58+ UbuntuShape {
59+ color: UbuntuColors.lightGrey
60+ }
61+ }
62+ TemplateRow {
63+ title: i18n.tr("Dark grey")
64+ UbuntuShape {
65+ color: UbuntuColors.darkGrey
66+ }
67+ }
68+ TemplateRow {
69+ title: i18n.tr("Red")
70+ UbuntuShape {
71+ color: UbuntuColors.red
72+ }
73+ }
74+ TemplateRow {
75+ title: i18n.tr("Green")
76+ UbuntuShape {
77+ color: UbuntuColors.green
78+ }
79+ }
80+ TemplateRow {
81+ title: i18n.tr("Blue")
82+ UbuntuShape {
83+ color: UbuntuColors.blue
84+ }
85+ }
86+ TemplateRow {
87+ title: i18n.tr("Purple")
88+ UbuntuShape {
89+ color: UbuntuColors.purple
90+ }
91+ }
92+ }
93+}
94
95=== modified file 'examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml'
96--- examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml 2014-07-02 13:39:29 +0000
97+++ examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml 2014-07-11 13:24:19 +0000
98@@ -28,7 +28,11 @@
99 label: "Styles"
100 source: "Styles.qml"
101 }
102-
103+ ListElement {
104+ objectName: "colorsElement"
105+ label: "Colors"
106+ source: "Colors.qml"
107+ }
108 ListElement {
109 objectName: "togglesElement"
110 label: "Toggles"
111
112=== modified file 'modules/Ubuntu/Components/Colors/FIXME'
113--- modules/Ubuntu/Components/Colors/FIXME 2013-07-01 05:54:33 +0000
114+++ modules/Ubuntu/Components/Colors/FIXME 2014-07-11 13:24:19 +0000
115@@ -1,3 +1,7 @@
116 UbuntuColors.qml is located in the Colors subdirectory because
117 QuickUtils::createQmlObject() fails if the QML file is located in a
118 folder that has a qmldir file with JavaScript modules.
119+
120+UbuntuColors 1.1 is not in a file named UbuntuColors11.qml but in
121+UbuntuColors.qml so that qdoc can properly detect the component
122+name without a qmldir file.
123
124=== added file 'modules/Ubuntu/Components/Colors/UbuntuColors.qml'
125--- modules/Ubuntu/Components/Colors/UbuntuColors.qml 1970-01-01 00:00:00 +0000
126+++ modules/Ubuntu/Components/Colors/UbuntuColors.qml 2014-07-11 13:24:19 +0000
127@@ -0,0 +1,131 @@
128+/*
129+ Copyright 2014 Canonical Ltd.
130+ *
131+ This program is free software; you can redistribute it and/or modify
132+ it under the terms of the GNU Lesser General Public License as published by
133+ the Free Software Foundation; version 3.
134+ *
135+ This program is distributed in the hope that it will be useful,
136+ but WITHOUT ANY WARRANTY; without even the implied warranty of
137+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
138+ GNU Lesser General Public License for more details.
139+ *
140+ You should have received a copy of the GNU Lesser General Public License
141+ along with this program. If not, see <http://www.gnu.org/licenses/>.
142+ */
143+
144+import QtQuick 2.2
145+
146+/*!
147+ \qmltype UbuntuColors
148+ \inqmlmodule Ubuntu.Components 1.1
149+ \ingroup ubuntu
150+ \brief Singleton defining the Ubuntu color palette.
151+
152+ Each color of the Ubuntu color palette is accesible from it.
153+ For more information on how to appropriately use the colors according to
154+ the context, please refer to the
155+ \l{http://design.ubuntu.com/brand/colour-palette}{Ubuntu brand guidelines}.
156+
157+ Example of use:
158+
159+ \qml
160+ Rectangle {
161+ color: UbuntuColors.orange
162+ }
163+ \endqml
164+*/
165+QtObject {
166+ // old colors from UbuntuColors 1.0:
167+
168+ /*!
169+ Orange. Recommended for branded elements, display progress
170+ and intensity, textual links on light backgrounds.
171+ */
172+ readonly property color orange: "#DD4814"
173+ /*!
174+ \deprecated
175+ Ubuntu supporting color: light aubergine
176+ */
177+ readonly property color lightAubergine: "#77216F"
178+ /*!
179+ \deprecated
180+ Ubuntu supporting color: mid aubergine
181+ */
182+ readonly property color midAubergine: "#5E2750"
183+ /*!
184+ \deprecated
185+ Ubuntu supporting color: dark aubergine
186+ */
187+ readonly property color darkAubergine: "#2C001E"
188+ /*!
189+ \deprecated
190+ Ubuntu neutral color: warm grey
191+ */
192+ readonly property color warmGrey: "#AEA79F"
193+ /*!
194+ \deprecated
195+ Ubuntu neutral color: cool grey
196+ */
197+ readonly property color coolGrey: "#333333"
198+
199+ /*!
200+ Ubuntu orange gradient
201+
202+ \sa Button::gradient
203+ */
204+ property Gradient orangeGradient: Gradient {
205+ GradientStop { position: 0.0; color: "#DD4814" }
206+ GradientStop { position: 1.0; color: "#D9722D" }
207+ }
208+ /*!
209+ Ubuntu grey gradient
210+
211+ \sa Button::gradient
212+ */
213+ property Gradient greyGradient: Gradient {
214+ GradientStop { position: 0.0; color: "#888888" }
215+ GradientStop { position: 1.0; color: "#BBBBBB" }
216+ }
217+
218+ // New colors introduced in UbuntuColors 1.1:
219+
220+ /*!
221+ Light grey. Recommended for neutral action buttons and
222+ secondary text.
223+ \since Ubuntu.Components 1.1
224+ */
225+ readonly property color lightGrey: "#888888"
226+
227+ /*!
228+ Dark grey. Recommended for text and action icons.
229+ \since Ubuntu.Components 1.1
230+ */
231+ readonly property color darkGrey: "#5d5d5d"
232+
233+ /*!
234+ Red. Recommended for negative and irreversible action
235+ buttons, errors and alerts.
236+ \since Ubuntu.Components 1.1
237+ */
238+ readonly property color red: "#fc4949"
239+
240+ /*!
241+ Green. Recommended for positive action buttons.
242+ \since Ubuntu.Components 1.1
243+ */
244+ readonly property color green: "#3fb24f"
245+
246+ /*!
247+ Blue. Recommended for text selection and text cursor.
248+ \since Ubuntu.Components 1.1
249+ */
250+ readonly property color blue: "#1ab6ef"
251+
252+ /*!
253+ Purple. Recommended for proper nouns in
254+ list items.
255+ \since Ubuntu.Components 1.1
256+ */
257+ readonly property color purple: "#762572"
258+}
259
260=== renamed file 'modules/Ubuntu/Components/Colors/UbuntuColors.qml' => 'modules/Ubuntu/Components/Colors/UbuntuColors10.qml'
261--- modules/Ubuntu/Components/Colors/UbuntuColors.qml 2013-07-02 00:15:07 +0000
262+++ modules/Ubuntu/Components/Colors/UbuntuColors10.qml 2014-07-11 13:24:19 +0000
263@@ -1,5 +1,5 @@
264 /*
265- Copyright 2013 Canonical Ltd.
266+ Copyright 2013-2014 Canonical Ltd.
267 *
268 This program is free software; you can redistribute it and/or modify
269 it under the terms of the GNU Lesser General Public License as published by
270@@ -14,67 +14,23 @@
271 along with this program. If not, see <http://www.gnu.org/licenses/>.
272 */
273
274-import QtQuick 2.0
275+import QtQuick 2.2
276
277 /*!
278- \qmltype UbuntuColors
279- \inqmlmodule Ubuntu.Components 0.1
280- \ingroup theming
281- \brief Singleton defining the Ubuntu color palette.
282-
283- Each color of the Ubuntu color palette is accesible from it.
284- For more information on how to appropriately use the colors according to
285- the context, please refer to the
286- \l{http://design.ubuntu.com/brand/colour-palette}{Ubuntu brand guidelines}.
287-
288- Example of use:
289-
290- \qml
291- Rectangle {
292- color: UbuntuColors.orange
293- }
294- \endqml
295+ \internal
296+ Documentation is in UbuntuColors.qml
297 */
298 QtObject {
299- /*!
300- Ubuntu core color: Ubuntu orange
301- */
302 readonly property color orange: "#DD4814"
303- /*!
304- Ubuntu supporting color: light aubergine
305- */
306 readonly property color lightAubergine: "#77216F"
307- /*!
308- Ubuntu supporting color: mid aubergine
309- */
310 readonly property color midAubergine: "#5E2750"
311- /*!
312- Ubuntu supporting color: dark aubergine
313- */
314 readonly property color darkAubergine: "#2C001E"
315- /*!
316- Ubuntu neutral color: warm grey
317- */
318 readonly property color warmGrey: "#AEA79F"
319- /*!
320- Ubuntu neutral color: cool grey
321- */
322 readonly property color coolGrey: "#333333"
323-
324- /*!
325- Ubuntu orange gradient
326-
327- \sa Button::gradient
328- */
329 property Gradient orangeGradient: Gradient {
330 GradientStop { position: 0.0; color: "#DD4814" }
331 GradientStop { position: 1.0; color: "#D9722D" }
332 }
333- /*!
334- Ubuntu grey gradient
335-
336- \sa Button::gradient
337- */
338 property Gradient greyGradient: Gradient {
339 GradientStop { position: 0.0; color: "#888888" }
340 GradientStop { position: 1.0; color: "#BBBBBB" }
341
342=== modified file 'modules/Ubuntu/Components/TextArea.qml'
343--- modules/Ubuntu/Components/TextArea.qml 2014-06-28 17:26:49 +0000
344+++ modules/Ubuntu/Components/TextArea.qml 2014-07-11 13:24:19 +0000
345@@ -850,7 +850,8 @@
346 }
347 color: control.__styleInstance.color
348 selectedTextColor: Theme.palette.selected.foregroundText
349- selectionColor: Theme.palette.selected.foreground
350+ property color selCol: Theme.palette.selected.foreground
351+ selectionColor: Qt.rgba(selCol.r, selCol.g, selCol.b, 0.2)
352 font.pixelSize: FontUtils.sizeToPixels("medium")
353 // forward keys to the root element so it can be captured outside of it
354 // as well as to InputHandler to handle PageUp/PageDown keys
355
356=== modified file 'modules/Ubuntu/Components/TextField.qml'
357--- modules/Ubuntu/Components/TextField.qml 2014-06-29 21:46:30 +0000
358+++ modules/Ubuntu/Components/TextField.qml 2014-07-11 13:24:19 +0000
359@@ -979,7 +979,8 @@
360 }
361 color: control.__styleInstance.color
362 selectedTextColor: Theme.palette.selected.foregroundText
363- selectionColor: Theme.palette.selected.foreground
364+ property color selCol: Theme.palette.selected.foreground
365+ selectionColor: Qt.rgba(selCol.r, selCol.g, selCol.b, 0.2)
366 font.pixelSize: FontUtils.sizeToPixels("medium")
367 passwordCharacter: "\u2022"
368 // forward keys to the root element so it can be captured outside of it
369
370=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/Palette.qml'
371--- modules/Ubuntu/Components/Themes/Ambiance/Palette.qml 2013-07-05 12:21:32 +0000
372+++ modules/Ubuntu/Components/Themes/Ambiance/Palette.qml 2014-07-11 13:24:19 +0000
373@@ -15,6 +15,7 @@
374 */
375
376 import QtQuick 2.0
377+import Ubuntu.Components 1.1
378 import Ubuntu.Components.Themes 0.1
379
380 Palette {
381@@ -22,13 +23,13 @@
382 background: "#EDEDED"
383 backgroundText: "#81888888"
384 base: "#1A000000"
385- baseText: "#888888"
386- foreground: "#888888"
387+ baseText: UbuntuColors.lightGrey
388+ foreground: UbuntuColors.lightGrey
389 foregroundText: "#F3F3E7"
390 overlay: "#FDFDFD"
391- overlayText: "#888888"
392+ overlayText: UbuntuColors.lightGrey
393 field: "#1A000000"
394- fieldText: "#888888"
395+ fieldText: UbuntuColors.darkGrey
396 }
397 selected: PaletteValues {
398 /* FIXME: 'background' does not come from design
399@@ -36,10 +37,10 @@
400 that will go away with the new design.
401 */
402 background: "#B2E6E6E6"
403- backgroundText: "#888888"
404- foreground: "#DD4814"
405- foregroundText: "#F3F3E7"
406+ backgroundText: UbuntuColors.darkGrey
407+ foreground: UbuntuColors.blue
408+ foregroundText: UbuntuColors.darkGrey
409 field: "#FFFFFF"
410- fieldText: "#888888"
411+ fieldText: UbuntuColors.darkGrey
412 }
413 }
414
415=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml'
416--- modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml 2014-05-09 05:25:12 +0000
417+++ modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml 2014-07-11 13:24:19 +0000
418@@ -70,7 +70,7 @@
419 // caretItem
420 Image {
421 id: caretItem
422- source: "artwork/teardrop-left.png"
423+ source: "artwork/caret_noshadow.png"
424 anchors {
425 top: parent.bottom
426 horizontalCenter: parent.horizontalCenter
427
428=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/TextSelectionEndCursorStyle.qml'
429--- modules/Ubuntu/Components/Themes/Ambiance/TextSelectionEndCursorStyle.qml 2014-05-09 05:25:12 +0000
430+++ modules/Ubuntu/Components/Themes/Ambiance/TextSelectionEndCursorStyle.qml 2014-07-11 13:24:19 +0000
431@@ -55,7 +55,7 @@
432 // caretItem
433 Image {
434 id: caretItem
435- source: "artwork/teardrop-left.png"
436+ source: "artwork/caret_noshadow.png"
437 anchors {
438 top: parent.bottom
439 horizontalCenter: parent.horizontalCenter
440
441=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/TextSelectionStartCursorStyle.qml'
442--- modules/Ubuntu/Components/Themes/Ambiance/TextSelectionStartCursorStyle.qml 2014-05-13 08:00:18 +0000
443+++ modules/Ubuntu/Components/Themes/Ambiance/TextSelectionStartCursorStyle.qml 2014-07-11 13:24:19 +0000
444@@ -55,12 +55,13 @@
445 // caretItem
446 Image {
447 id: caretItem
448- source: "artwork/teardrop-right.png"
449+ source: "artwork/caret_noshadow.png"
450 anchors {
451- top: parent.bottom
452+ bottom: parent.top
453 horizontalCenter: parent.horizontalCenter
454 topMargin: -units.gu(0.5)
455 horizontalCenterOffset: LayoutMirroring.enabled ? -(units.gu(0.7) - caretItem.width) : -units.gu(0.7)
456 }
457+ rotation: 180
458 }
459 }
460
461=== added file 'modules/Ubuntu/Components/Themes/Ambiance/artwork/caret_noshadow@27.png'
462Binary files modules/Ubuntu/Components/Themes/Ambiance/artwork/caret_noshadow@27.png 1970-01-01 00:00:00 +0000 and modules/Ubuntu/Components/Themes/Ambiance/artwork/caret_noshadow@27.png 2014-07-11 13:24:19 +0000 differ
463=== removed file 'modules/Ubuntu/Components/Themes/Ambiance/artwork/teardrop-left@20.png'
464Binary files modules/Ubuntu/Components/Themes/Ambiance/artwork/teardrop-left@20.png 2014-04-25 08:18:46 +0000 and modules/Ubuntu/Components/Themes/Ambiance/artwork/teardrop-left@20.png 1970-01-01 00:00:00 +0000 differ
465=== removed file 'modules/Ubuntu/Components/Themes/Ambiance/artwork/teardrop-right@20.png'
466Binary files modules/Ubuntu/Components/Themes/Ambiance/artwork/teardrop-right@20.png 2014-04-25 08:18:46 +0000 and modules/Ubuntu/Components/Themes/Ambiance/artwork/teardrop-right@20.png 1970-01-01 00:00:00 +0000 differ
467=== modified file 'modules/Ubuntu/Components/Themes/SuruDark/Palette.qml'
468--- modules/Ubuntu/Components/Themes/SuruDark/Palette.qml 2013-07-05 14:34:00 +0000
469+++ modules/Ubuntu/Components/Themes/SuruDark/Palette.qml 2014-07-11 13:24:19 +0000
470@@ -15,6 +15,7 @@
471 */
472
473 import QtQuick 2.0
474+import Ubuntu.Components 1.1
475 import Ubuntu.Components.Themes 0.1
476
477 Palette {
478@@ -33,8 +34,8 @@
479 selected: PaletteValues {
480 background: "#88D6D6D6" // FIXME: not from design
481 backgroundText: "#F3F3E7"
482- foreground: "#DD4814"
483- foregroundText: "#F3F3E7"
484+ foreground: UbuntuColors.blue
485+ foregroundText: UbuntuColors.darkGrey
486 field: "#FFFFFF"
487 fieldText: "#888888"
488 }
489
490=== modified file 'modules/Ubuntu/Components/plugin/plugin.cpp'
491--- modules/Ubuntu/Components/plugin/plugin.cpp 2014-06-10 11:47:09 +0000
492+++ modules/Ubuntu/Components/plugin/plugin.cpp 2014-07-11 13:24:19 +0000
493@@ -92,7 +92,14 @@
494 return uriHandler;
495 }
496
497-static QObject *registerUbuntuColors(QQmlEngine *engine, QJSEngine *scriptEngine)
498+static QObject *registerUbuntuColors10(QQmlEngine *engine, QJSEngine *scriptEngine)
499+{
500+ Q_UNUSED(scriptEngine)
501+ return UbuntuComponentsPlugin::registerQmlSingletonType(engine,
502+ "Ubuntu.Components", "Colors/UbuntuColors10.qml");
503+}
504+
505+static QObject *registerUbuntuColors11(QQmlEngine *engine, QJSEngine *scriptEngine)
506 {
507 Q_UNUSED(scriptEngine)
508 return UbuntuComponentsPlugin::registerQmlSingletonType(engine,
509@@ -154,7 +161,7 @@
510
511 void UbuntuComponentsPlugin::registerTypesToVersion(const char *uri, int major, int minor)
512 {
513- qmlRegisterSingletonType<QObject>(uri, major, minor, "UbuntuColors", registerUbuntuColors);
514+ qmlRegisterSingletonType<QObject>(uri, major, minor, "UbuntuColors", registerUbuntuColors10);
515 qmlRegisterUncreatableType<UbuntuI18n>(uri, major, minor, "i18n", "Singleton object");
516 qmlRegisterExtendedType<QQuickImageBase, UCQQuickImageExtension>(uri, major, minor, "QQuickImageBase");
517 qmlRegisterUncreatableType<UCUnits>(uri, major, minor, "UCUnits", "Not instantiable");
518@@ -184,6 +191,7 @@
519 // register 0.1 for backward compatibility
520 registerTypesToVersion(uri, 0, 1);
521 registerTypesToVersion(uri, 1, 0);
522+ qmlRegisterSingletonType<QObject>(uri, 1, 1, "UbuntuColors", registerUbuntuColors11);
523
524 // register custom event
525 ForwardedEvent::registerForwardedEvent();
526
527=== modified file 'tests/unit_x11/tst_components/tst_textinput_touch.qml'
528--- tests/unit_x11/tst_components/tst_textinput_touch.qml 2014-06-24 08:42:47 +0000
529+++ tests/unit_x11/tst_components/tst_textinput_touch.qml 2014-07-11 13:24:19 +0000
530@@ -192,15 +192,15 @@
531 verify(selectedText !== "", "No text selected!");
532
533 popupSpy.target = findChild(data.input, "input_handler");
534- TestExtras.touchLongPress(0, data.input, guPoint(1, 1));
535+ TestExtras.touchLongPress(0, data.input, guPoint(2, 2));
536 waitForRendering(data.input, 500);
537 popupSpy.wait();
538 compare(data.input.selectedText, selectedText, "Text selection should be the same!");
539
540 // cleanup
541- TestExtras.touchRelease(0, data.input, guPoint(1, 1));
542+ TestExtras.touchRelease(0, data.input, guPoint(2, 2));
543 // dismiss popover
544- TestExtras.touchClick(0, testMain, 0, 0);
545+ TestExtras.touchClick(0, testMain, guPoint(0, 0));
546 }
547
548 function test_drag_cursor_handler_data() {
549@@ -275,9 +275,7 @@
550 flickerSpy.target = outerFlicker;
551 autoSizeTextArea.focus = data.focused;
552 var editor = findChild(autoSizeTextArea, "text_input");
553- wait(5000)
554 TestExtras.touchDrag(0, editor, guPoint(0, 0), guPoint(0, 40));
555- wait(5000)
556 flickerSpy.wait();
557 }
558 }

Subscribers

People subscribed via source and target branches