lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/acceptTheComboButton

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-ui-toolkit/staging at revision 2043

ubuntu-sdk-build-bot: Approve (continuous-integration) on 2016-07-26

Tim Peeters: Approve on 2016-07-26

Diff: 264 lines (+59/-23)

7 files modified

examples/ubuntu-ui-toolkit-gallery/Buttons.qml (+8/-8)
src/Ubuntu/Components/1.3/ComboButton.qml (+13/-0)
src/Ubuntu/Components/Themes/Ambiance/1.3/ComboButtonStyle.qml (+5/-1)
src/Ubuntu/UbuntuToolkit/ucabstractbutton.cpp (+1/-1)
src/Ubuntu/UbuntuToolkit/ucstyleditembase_p.h (+1/-1)
tests/unit/visual/tst_combobutton.13.qml (+23/-10)
tests/unit/visual/tst_focus.13.qml (+8/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1523817: ComboButton needs keyboard support

Medium

Fix Released

Link a bug report

Related blueprints

2002. By Cris Dywan on 2016-07-22

Fix dropdown button focussing the main item

2001. By Cris Dywan on 2016-07-14

Merge lp:ubuntu-ui-toolkit/staging

2000. By Cris Dywan on 2016-07-14

AbstractButton shouldn't act as a FocusScope

1999. By Cris Dywan on 2016-07-14

AbstractButton shouldn't by default accept Tab

This is enabled in the styles that support focus. Invisible
(Shift)Tab movement out of the box is not useful.

1998. By Cris Dywan on 2016-07-14

Put the ComboButton back in charge of its own keyNavigationFocus

1997. By Cris Dywan on 2016-07-14

Use ListItem(WithLabel) for ComboButton's in the gallery

1996. By Cris Dywan on 2016-06-21

Add internal comment for ComboButton.keyNavigationFocus

1995. By Cris Dywan on 2016-06-20

Alias activeFocusOnTab rather than unsetting it

Otherwise the component seemingly doesn't support focus.

1994. By Cris Dywan on 2016-06-16

Use tryCompare when checking combo height/ expansion

1993. By Cris Dywan on 2016-06-16

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging