autopkgtest-cloud

Merge autopkgtest-cloud:run-autopkgtest-args into autopkgtest-cloud:master

  1. Git
  2. lp:autopkgtest-cloud
  3. run-autopkgtest-args
  4. Merge into master
Proposed by Brian Murray
Status: Merged
Merged at revision: 8d035c8eb26bbada7922dcf3adb0a2e1340a92e9
Proposed branch: autopkgtest-cloud:run-autopkgtest-args
Merge into: autopkgtest-cloud:master
Diff against target: 27 lines (+5/-3)
1 file modified
charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/run-autopkgtest (+5/-3)
Reviewer Review Type Date Requested Status
Paride Legovini Approve
Ubuntu Release Team Pending
Review via email: mp+434009@code.launchpad.net

Description of the change

Clarify what is really required.

ubuntu@juju-806ee7-stg-proposed-migration-58:~$ autopkgtest-cloud/tools/run-autopkgtest -s lunar apport
usage: run-autopkgtest [-h] -s SERIES [-a ARCHITECTURE] [--trigger SOURCE/VERSION] [--ppa LPUSER/PPANAME] [--env KEY=VALUE]
                       [--test-git URL [branchname]] [--build-git URL [branchname]] [--test-bzr TEST_BZR] [--swiftuser SWIFTUSER]
                       [--readable-by LP team/username] [--all-proposed] [--bulk]
                       package [package ...]
run-autopkgtest: error: One of --trigger or --ppa must be given

ubuntu@juju-806ee7-stg-proposed-migration-58:~$ autopkgtest-cloud/tools/run-autopkgtest --trigger apport/2.23.1-0ubuntu3 -s lunar apport
usage: run-autopkgtest [-h] -s SERIES [-a ARCHITECTURE] [--trigger SOURCE/VERSION] [--ppa LPUSER/PPANAME] [--env KEY=VALUE]
                       [--test-git URL [branchname]] [--build-git URL [branchname]] [--test-bzr TEST_BZR] [--swiftuser SWIFTUSER]
                       [--readable-by LP team/username] [--all-proposed] [--bulk]
                       package [package ...]
run-autopkgtest: error: --architecture must be given

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/run-autopkgtest b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/run-autopkgtest
2index febd6ea..a09ad42 100755
3--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/run-autopkgtest
4+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/run-autopkgtest
5@@ -25,17 +25,19 @@ def parse_args():
6 parser.add_argument(
7 "-a",
8 "--architecture",
9+ required=True,
10 action="append",
11 default=[],
12- help="Only run test(s) on given architecture name(s). "
13- "Can be specified multiple times (default: all).",
14+ help="Only run test(s) on given architecture name(s) (required). "
15+ "Can be specified multiple times.",
16 )
17 parser.add_argument(
18 "--trigger",
19+ required=True,
20 action="append",
21 default=[],
22 metavar="SOURCE/VERSION",
23- help="Add triggering package to request. "
24+ help="Add triggering package to request (required). "
25 "Can be specified multiple times.",
26 )
27 parser.add_argument(

Subscribers

People subscribed via source and target branches